Page MenuHomeSoftware Heritage
Differential D4141

lister*: Migrate away from SWHConfig mixin
ClosedPublic
Actions

Authored by ardumont on Oct 5 2020, 12:53 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T1410: Kill implicit configuration: new configuration scheme
T1532: Cleanup deprecated configuration code in swh modules
Commits
rDLS56f08b73f6b0: lister*: Migrate away from SWHConfig mixin
Summary

Related to T1532 T1410 D3965

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15885
Build 24450: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 24449: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 5 2020, 12:53 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2020, 12:53 PM
swh-public-ci added a comment.Oct 5 2020, 12:56 PM

Build is green

Patch application report for D4141 (id=14599)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit 23dce4f9232b58175e64e75d53de64b5807d535b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/49/ for more details.

Harbormaster completed remote builds in B15880: Diff 14599.Oct 5 2020, 12:56 PM
ardumont mentioned this in T1532: Cleanup deprecated configuration code in swh modules.Oct 5 2020, 12:59 PM
ardumont updated this revision to Diff 14600.Oct 5 2020, 1:01 PM

Fix cached_dir typo

ardumont updated this revision to Diff 14601.Oct 5 2020, 1:02 PM

Rename conffile into conf_path

swh-public-ci added a comment.Oct 5 2020, 1:04 PM

Build is green

Patch application report for D4141 (id=14600)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit c9aff5dea55592d9d1b91cbdc33704f9715fcaa6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/50/ for more details.

Harbormaster completed remote builds in B15881: Diff 14600.Oct 5 2020, 1:04 PM
swh-public-ci added a comment.Oct 5 2020, 1:07 PM

Build is green

Patch application report for D4141 (id=14601)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit 763d813bf291d554eaafe00a3363bb16b9b5d25e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/51/ for more details.

Harbormaster completed remote builds in B15882: Diff 14601.Oct 5 2020, 1:07 PM
ardumont updated this revision to Diff 14602.Oct 5 2020, 1:25 PM

Simplify cache instruction fallback

swh-public-ci added a comment.Oct 5 2020, 1:26 PM

Build has FAILED

Patch application report for D4141 (id=14602)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit b50fbe5dbad4996c60ba6932163b227dd7612280
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/52/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/52/console

Harbormaster failed remote builds in B15883: Diff 14602!Oct 5 2020, 1:26 PM
ardumont updated this revision to Diff 14603.Oct 5 2020, 1:27 PM

Fix

swh-public-ci added a comment.Oct 5 2020, 1:27 PM

Build has FAILED

Patch application report for D4141 (id=14603)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit 5383de225ac95bbb9b76a4a09901cdee1e1be289
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/53/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/53/console

Harbormaster failed remote builds in B15884: Diff 14603!Oct 5 2020, 1:27 PM
ardumont updated this revision to Diff 14604.Oct 5 2020, 1:29 PM

Fix line too long

(getting annoying especially for an unused part)

swh-public-ci added a comment.Oct 5 2020, 1:32 PM

Build is green

Patch application report for D4141 (id=14604)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit 56f08b73f6b0122bf921b0e9920f5489d7ccb937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/54/ for more details.

Harbormaster completed remote builds in B15885: Diff 14604.Oct 5 2020, 1:32 PM
ardumont added inline comments.Oct 5 2020, 1:33 PM
swh/lister/core/lister_base.py
237

I won't add tests for that part.
It's unused and most likely get scratched soon.

vlorentz accepted this revision.Oct 5 2020, 5:56 PM
This revision is now accepted and ready to land.Oct 5 2020, 5:56 PM
Closed by commit rDLS56f08b73f6b0: lister*: Migrate away from SWHConfig mixin (authored by ardumont). · Explain WhyOct 5 2020, 7:17 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLS56f08b73f6b0: lister*: Migrate away from SWHConfig mixin.
ardumont added inline comments.Oct 7 2020, 2:00 PM
swh/lister/core/lister_base.py
48

roh, come on, i forgot to remove that...
Related to D4178...

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
lister/
core/
39 lines82%
Loading...
npm/
15 lines73%
Loading...
25 lines96%
Loading...

Diff 14604

View Options

swh/lister/core/lister_base.py

Loading...
View Options

swh/lister/npm/lister.py

Loading...
View Options

swh/lister/pytest_plugin.py

Loading...
About · Developer information · Legal