Page MenuHomeSoftware Heritage

lister*: Migrate away from SWHConfig mixin
ClosedPublic

Authored by ardumont on Oct 5 2020, 12:53 PM.

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15880
Build 24440: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 24439: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4141 (id=14599)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit 23dce4f9232b58175e64e75d53de64b5807d535b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/49/ for more details.

Rename conffile into conf_path

Build is green

Patch application report for D4141 (id=14600)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit c9aff5dea55592d9d1b91cbdc33704f9715fcaa6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/50/ for more details.

Build is green

Patch application report for D4141 (id=14601)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit 763d813bf291d554eaafe00a3363bb16b9b5d25e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/51/ for more details.

Simplify cache instruction fallback

Build has FAILED

Patch application report for D4141 (id=14602)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit b50fbe5dbad4996c60ba6932163b227dd7612280
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/52/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/52/console

Build has FAILED

Patch application report for D4141 (id=14603)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit 5383de225ac95bbb9b76a4a09901cdee1e1be289
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/53/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/53/console

Fix line too long

(getting annoying especially for an unused part)

Build is green

Patch application report for D4141 (id=14604)

Rebasing onto 4d6b99188e...

Current branch diff-target is up to date.
Changes applied before test
commit 56f08b73f6b0122bf921b0e9920f5489d7ccb937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 5 12:54:15 2020 +0200

    lister*: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/54/ for more details.

swh/lister/core/lister_base.py
237

I won't add tests for that part.
It's unused and most likely get scratched soon.

This revision is now accepted and ready to land.Oct 5 2020, 5:56 PM
swh/lister/core/lister_base.py
48

roh, come on, i forgot to remove that...
Related to D4178...