Page MenuHomeSoftware Heritage
Differential D3978

tests: Don't check the number of created 'person' objects.
ClosedPublic
Actions

Authored by vlorentz on Sep 17 2020, 2:51 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDLDGeafb0a64c49c: tests: Don't check the number of created 'person' objects.
Summary

They are an implementation detail of storage backends; and get_stats() will
stop returning the 'person' count in the next version of swh-storage-core.

Additionally, D3976 changes the values of these counters.

Fixes [1]

[1] https://jenkins.softwareheritage.org/job/DLDG/job/tests/819/console

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15239
Build 23490: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23489: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 17 2020, 2:51 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 17 2020, 2:51 PM
vlorentz edited the test plan for this revision. (Show Details)Sep 17 2020, 2:52 PM
swh-public-ci added a comment.Sep 17 2020, 2:52 PM

Build has FAILED

Patch application report for D3978 (id=14012)

Rebasing onto 4d1cf9d96f...

First, rewinding head to replay your work on top of it...
Applying: tests: Don't check the number of created 'person' objects.
Changes applied before test
commit 7dfd1b81f9e9e3e44b2249ea45875d05d3f8cba3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 17 14:50:24 2020 +0200

    tests: Don't check the number of created 'person' objects.
    
    They are an implementation detail of storage backends; and get_stats() will
    stop returning the 'person' count in the next version of swh-storage-core.

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/56/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/56/console

Harbormaster failed remote builds in B15239: Diff 14012!Sep 17 2020, 2:52 PM
olasd accepted this revision.Sep 17 2020, 2:54 PM
This revision is now accepted and ready to land.Sep 17 2020, 2:54 PM
ardumont edited the summary of this revision. (Show Details)Sep 18 2020, 11:15 AM
ardumont edited the test plan for this revision. (Show Details)
ardumont added a project: Git loader.
swh-public-ci added a comment.Sep 18 2020, 11:16 AM

Build is green

Patch application report for D3978 (id=14012)

Rebasing onto d733c4c484...

First, rewinding head to replay your work on top of it...
Applying: tests: Don't check the number of created 'person' objects.
Changes applied before test
commit 1e30ec6bc3487d112593a33229d85439e3d546a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 17 14:50:24 2020 +0200

    tests: Don't check the number of created 'person' objects.
    
    They are an implementation detail of storage backends; and get_stats() will
    stop returning the 'person' count in the next version of swh-storage-core.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/57/ for more details.

Harbormaster completed remote builds in B15239: Diff 14012.Sep 18 2020, 11:16 AM
vlorentz updated this revision to Diff 14046.Sep 18 2020, 11:18 AM

rebase

This revision was landed with ongoing or failed builds.Sep 18 2020, 11:18 AM
Closed by commit rDLDGeafb0a64c49c: tests: Don't check the number of created 'person' objects. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDGeafb0a64c49c: tests: Don't check the number of created 'person' objects..
swh-public-ci added a comment.Sep 18 2020, 11:19 AM

Build is green

Patch application report for D3978 (id=14046)

Rebasing onto eafb0a64c4...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-58-D3978.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/58/ for more details.
Harbormaster completed remote builds in B15317: Diff 14046.Sep 18 2020, 11:19 AM
ardumont mentioned this in D3984: tests: Don't check the number of created 'person' objects.Sep 18 2020, 1:27 PM
ardumont mentioned this in D3985: tests: Don't check the number of created 'person' objects.
Revision Contents
Changeset List
PathSizeCoverage (All)Coverage (Touched)
2 lines--
swh/
loader/
git/
tests/
5 lines100%
Loading...
Diff 14012
View Options
requirements-swh.txt
Loading...
View Options
swh/loader/git/tests/test_from_disk.py
Loading...
About · Developer information · Legal