Differential D3985

tests: Don't check the number of created 'person' objects
ClosedPublic
Actions

Authored by ardumont on Sep 18 2020, 1:26 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDLDSVN47b03e19593d: tests: Don't check the number of created 'person' objects

Summary

They are an implementation detail of storage backends; and get_stats() will
stop returning the 'person' count in the next version of swh-storage-core.

Fixes build [1]

[1] https://jenkins.softwareheritage.org/job/DLDSVN/job/tests/820/console
[2] https://jenkins.softwareheritage.org/job/DENV/job/tests/lastBuild/console

Similar to D3978

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 18 2020, 1:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 18 2020, 1:26 PM

Build is green

Patch application report for D3985 (id=14054)

Rebasing onto 40f407c718...

Current branch diff-target is up to date.

Changes applied before test

commit 47b03e19593ddaf438a1036703042fb0ab911f16
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 18 13:26:17 2020 +0200

    tests: Don't check the number of created 'person' objects
    
    Fixes build [1]
    
    [1] https://jenkins.softwareheritage.org/job/DLDSVN/job/tests/820/console
    [2] https://jenkins.softwareheritage.org/job/DENV/job/tests/lastBuild/console

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/95/ for more details.

Harbormaster completed remote builds in B15325: Diff 14054.Sep 18 2020, 1:27 PM

ardumont edited the summary of this revision. (Show Details)Sep 18 2020, 1:27 PM

olasd accepted this revision.Sep 18 2020, 2:49 PM

This revision is now accepted and ready to land.Sep 18 2020, 2:49 PM

Closed by commit rDLDSVN47b03e19593d: tests: Don't check the number of created 'person' objects (authored by ardumont). · Explain WhySep 18 2020, 3:17 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN47b03e19593d: tests: Don't check the number of created 'person' objects.