Paths

Table of Contentst

sql: Make the extra_headers not null a constraint
ClosedPublic
Actions

Authored by ardumont on Sep 14 2020, 10:59 AM.

Details

Reviewers

vlorentz
olasd

Group Reviewers

Reviewers

Maniphest Tasks

T2547: pgstorage: Migrate db to storage 0.13.2 (db versions 160, 161)

Commits

rDSTO3b781a8a523c: sql: Make the extra_headers not null a constraint

Summary

Due to the data volume, the basic not null instruction constraint which is
blocking impose us downtime for loaders otherwise.

Related to T2547

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15096
Build 23275: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23274: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 14 2020, 10:59 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 14 2020, 10:59 AM

Build is green

Patch application report for D3936 (id=13869)

Rebasing onto ed55e9c775...

First, rewinding head to replay your work on top of it...
Applying: sql: Make the extra_headers not null a constraint

Changes applied before test

commit a9601712a106e4847fd91ff58298efa5982aa28b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 14 10:58:59 2020 +0200

    sql: Make the extra_headers not null a constraint
    
    Due to the data volume, the basic not null instruction constraint which is
    blocking impose us downtime for loaders otherwise.
    
    Related to T2547

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/931/ for more details.

Harbormaster completed remote builds in B15093: Diff 13869.Sep 14 2020, 11:04 AM

vlorentz accepted this revision.Sep 14 2020, 11:05 AM

This revision is now accepted and ready to land.Sep 14 2020, 11:05 AM

As there has been a release with the not null column property, this should be a new version of the database schema so people who deployed recently can get this change.

But as the old version (not null column property) and the new version (not null constraint) are functionally equivalent, I'm not sure whether we really need to do one more migration here.

This revision now requires changes to proceed.Sep 14 2020, 11:13 AM

Do you mean you want me to move this into 163.sql?

ardumont mentioned this in T2547: pgstorage: Migrate db to storage 0.13.2 (db versions 160, 161).Sep 14 2020, 12:24 PM

ok, i think you meant i only need to change 161.sql and the remaining can stay as before as it is functionally equivalent.

Only modify the 161.sql script

Build is green

Patch application report for D3936 (id=13871)

Rebasing onto ed55e9c775...

Current branch diff-target is up to date.

Changes applied before test

commit 3b781a8a523ca73fea815f79d339802362fa7705
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 14 13:07:31 2020 +0200

    sql: Make the extra_headers not null a constraint
    
    Due to the data volume, the basic not null instruction constraint (which is
    blocking) impose us downtime for loaders otherwise.
    
    Related to T2547

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/932/ for more details.

Harbormaster completed remote builds in B15096: Diff 13871.Sep 14 2020, 1:11 PM

olasd accepted this revision.Sep 14 2020, 2:37 PM

This revision is now accepted and ready to land.Sep 14 2020, 2:37 PM

Closed by commit rDSTO3b781a8a523c: sql: Make the extra_headers not null a constraint (authored by ardumont). · Explain WhySep 14 2020, 2:38 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO3b781a8a523c: sql: Make the extra_headers not null a constraint.