Page MenuHomeSoftware Heritage

sql: Make the extra_headers not null a constraint
ClosedPublic

Authored by ardumont on Mon, Sep 14, 10:59 AM.

Details

Summary

Due to the data volume, the basic not null instruction constraint which is
blocking impose us downtime for loaders otherwise.

Related to T2547

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mon, Sep 14, 10:59 AM

Build is green

Patch application report for D3936 (id=13869)

Rebasing onto ed55e9c775...

First, rewinding head to replay your work on top of it...
Applying: sql: Make the extra_headers not null a constraint
Changes applied before test
commit a9601712a106e4847fd91ff58298efa5982aa28b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 14 10:58:59 2020 +0200

    sql: Make the extra_headers not null a constraint
    
    Due to the data volume, the basic not null instruction constraint which is
    blocking impose us downtime for loaders otherwise.
    
    Related to T2547

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/931/ for more details.

vlorentz accepted this revision.Mon, Sep 14, 11:05 AM
This revision is now accepted and ready to land.Mon, Sep 14, 11:05 AM
olasd requested changes to this revision.Mon, Sep 14, 11:13 AM
olasd added a subscriber: olasd.

As there has been a release with the not null column property, this should be a new version of the database schema so people who deployed recently can get this change.

But as the old version (not null column property) and the new version (not null constraint) are functionally equivalent, I'm not sure whether we really need to do one more migration here.

This revision now requires changes to proceed.Mon, Sep 14, 11:13 AM
ardumont added a comment.EditedMon, Sep 14, 12:04 PM

Do you mean you want me to move this into 163.sql?

ok, i think you meant i only need to change 161.sql and the remaining can stay as before as it is functionally equivalent.

ardumont updated this revision to Diff 13871.Mon, Sep 14, 1:06 PM

Only modify the 161.sql script

Build is green

Patch application report for D3936 (id=13871)

Rebasing onto ed55e9c775...

Current branch diff-target is up to date.
Changes applied before test
commit 3b781a8a523ca73fea815f79d339802362fa7705
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 14 13:07:31 2020 +0200

    sql: Make the extra_headers not null a constraint
    
    Due to the data volume, the basic not null instruction constraint (which is
    blocking) impose us downtime for loaders otherwise.
    
    Related to T2547

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/932/ for more details.

olasd accepted this revision.Mon, Sep 14, 2:37 PM
This revision is now accepted and ready to land.Mon, Sep 14, 2:37 PM
This revision was automatically updated to reflect the committed changes.