glob.glob doesn't match some wildcards and since the pattern is translated by fnmatch this check can be removed.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDTSCNf838fed672d8: cli: don't check for glob pattern before translating into regex
Diff Detail
Diff Detail
- Repository
- rDTSCN Code scanner
- Branch
- exclude-pattern-fix
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15038 Build 23176: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 23175: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 4 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_cli::test_extract_regex_objs temp_folder = {'filesample': PosixPath('/tmp/pytest-of-jenkins/pytest-0/subdir0/filesample.txt'), 'filesample2': PosixPath('/tmp/pyt... 'swh:1:dir:4b825dc642cb6eb9a060e54bf8d69288fbee4904', ...}, 'root': PosixPath('/tmp/pytest-of-jenkins/pytest-0'), ...}
def test_extract_regex_objs(temp_folder):
| |
| 3 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_dashboard::test_generate_table_body | |
| 2 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_model::test_get_directories_info | |
| 2 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_model::test_get_files_from_dir | |
| 2 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_model::test_get_files_from_dir_raise_exception | |
| View Full Test Results (1 Failed · 19 Passed) |
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3924 (id=13813)
Rebasing onto 2fb9cb1c59...
Current branch diff-target is up to date.
Changes applied before test
commit 573f1504798dc1e6bcc73aa98b5196841f904d81
Author: Daniele Serafini <me@danieleserafini.eu>
Date: Thu Sep 10 17:46:47 2020 +0200
cli: don't check for glob pattern before translating into regexLink to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/44/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/44/console
Comment Actions
Build is green
Patch application report for D3924 (id=13815)
Rebasing onto 2fb9cb1c59...
Current branch diff-target is up to date.
Changes applied before test
commit f838fed672d8f20a81fd819e1b06d5bd7bb03c29
Author: Daniele Serafini <me@danieleserafini.eu>
Date: Thu Sep 10 17:46:47 2020 +0200
cli: don't check for glob pattern before translating into regexSee https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/45/ for more details.