cli: don't check for glob pattern before translating into regex
ClosedPublic
Actions

Authored by DanSeraf on Sep 10 2020, 6:05 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDTSCNf838fed672d8: cli: don't check for glob pattern before translating into regex

Summary

glob.glob doesn't match some wildcards and since the pattern is translated by fnmatch this check can be removed.

Diff Detail

Repository

rDTSCN Code scanner

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

DanSeraf created this revision.Sep 10 2020, 6:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 10 2020, 6:05 PM

Build has FAILED

Patch application report for D3924 (id=13813)

Rebasing onto 2fb9cb1c59...

Current branch diff-target is up to date.

Changes applied before test

commit 573f1504798dc1e6bcc73aa98b5196841f904d81
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Thu Sep 10 17:46:47 2020 +0200

    cli: don't check for glob pattern before translating into regex

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/44/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/44/console

Harbormaster failed remote builds in B15038: Diff 13813!Sep 10 2020, 6:07 PM

vlorentz accepted this revision.Sep 10 2020, 6:47 PM

This revision is now accepted and ready to land.Sep 10 2020, 6:47 PM

tests

Build is green

Patch application report for D3924 (id=13815)

Rebasing onto 2fb9cb1c59...

Current branch diff-target is up to date.

Changes applied before test

commit f838fed672d8f20a81fd819e1b06d5bd7bb03c29
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Thu Sep 10 17:46:47 2020 +0200

    cli: don't check for glob pattern before translating into regex

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/45/ for more details.

Harbormaster completed remote builds in B15040: Diff 13815.Sep 11 2020, 9:18 AM

Closed by commit rDTSCNf838fed672d8: cli: don't check for glob pattern before translating into regex (authored by DanSeraf). · Explain WhySep 11 2020, 9:20 AM

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDTSCNf838fed672d8: cli: don't check for glob pattern before translating into regex.