Page MenuHomeSoftware Heritage

cli: don't check for glob pattern before translating into regex
ClosedPublic

Authored by DanSeraf on Sep 10 2020, 6:05 PM.

Details

Summary

glob.glob doesn't match some wildcards and since the pattern is translated by fnmatch this check can be removed.

Diff Detail

Repository
rDTSCN Code scanner
Branch
exclude-pattern-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15040
Build 23180: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23179: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D3924 (id=13813)

Rebasing onto 2fb9cb1c59...

Current branch diff-target is up to date.
Changes applied before test
commit 573f1504798dc1e6bcc73aa98b5196841f904d81
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Thu Sep 10 17:46:47 2020 +0200

    cli: don't check for glob pattern before translating into regex

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/44/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/44/console

This revision is now accepted and ready to land.Sep 10 2020, 6:47 PM

Build is green

Patch application report for D3924 (id=13815)

Rebasing onto 2fb9cb1c59...

Current branch diff-target is up to date.
Changes applied before test
commit f838fed672d8f20a81fd819e1b06d5bd7bb03c29
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Thu Sep 10 17:46:47 2020 +0200

    cli: don't check for glob pattern before translating into regex

See https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/45/ for more details.