Page MenuHomeSoftware Heritage

storage_tests: Remove duplicated postgresql-specific tests.
ClosedPublic

Authored by vlorentz on Aug 20 2020, 3:57 PM.

Details

Summary

They got copied to test_postgresql.py instead of moved.

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14712
Build 22668: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 22667: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3821 (id=13446)

Rebasing onto 3ac332ecbf...

Current branch diff-target is up to date.
Changes applied before test
commit 07018f633c2594aae6d2c1ed45dcb9f530d93048
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 15:57:35 2020 +0200

    storage_tests: Remove duplicated postgresql-specific tests.
    
    They got copied to test_postgresql.py instead of moved.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/834/ for more details.

anlambert added inline comments.
swh/storage/tests/storage_tests.py
94–108

I put that function in storage.utils and its test to storage.tests.test_utils (as pytest will not try to discover tests in storage_tests.py) in my previous commit.

Why reintroducing those here ?

swh/storage/tests/storage_tests.py
94–108

because I'm an idiot who can't use git properly

unrevert round_to_milliseconds changes

Build is green

Patch application report for D3821 (id=13447)

Rebasing onto 3ac332ecbf...

Current branch diff-target is up to date.
Changes applied before test
commit 1aafcf9907f07554e2512680d54227847f46a66f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 15:57:35 2020 +0200

    storage_tests: Remove duplicated postgresql-specific tests.
    
    They got copied to test_postgresql.py instead of moved.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/835/ for more details.

Build is green

Patch application report for D3821 (id=13448)

Rebasing onto 3ac332ecbf...

Current branch diff-target is up to date.
Changes applied before test
commit 5390a4cc0aad9182f62e8555db1efecba1f2dbc5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 16:04:30 2020 +0200

    storage_tests: Remove duplicated postgresql-specific tests.
    
    They got copied to test_postgresql.py instead of moved.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/836/ for more details.

This revision is now accepted and ready to land.Aug 20 2020, 4:14 PM