Paths

Table of Contentst

Differential D3821

storage_tests: Remove duplicated postgresql-specific tests.
ClosedPublic
Actions

Authored by vlorentz on Aug 20 2020, 3:57 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSTO5390a4cc0aad: storage_tests: Remove duplicated postgresql-specific tests.

Summary

They got copied to test_postgresql.py instead of moved.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14712
Build 22668: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22667: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 20 2020, 3:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2020, 3:57 PM

remove dead code

Build is green

Patch application report for D3821 (id=13446)

Rebasing onto 3ac332ecbf...

Current branch diff-target is up to date.

Changes applied before test

commit 07018f633c2594aae6d2c1ed45dcb9f530d93048
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 15:57:35 2020 +0200

    storage_tests: Remove duplicated postgresql-specific tests.
    
    They got copied to test_postgresql.py instead of moved.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/834/ for more details.

Harbormaster completed remote builds in B14710: Diff 13446.Aug 20 2020, 4:02 PM

anlambert added a subscriber: anlambert.Aug 20 2020, 4:04 PM

anlambert added inline comments.

swh/storage/tests/storage_tests.py
94–108	I put that function in `storage.utils` and its test to `storage.tests.test_utils` (as pytest will not try to discover tests in `storage_tests.py`) in my previous commit. Why reintroducing those here ?

vlorentz added inline comments.Aug 20 2020, 4:05 PM

swh/storage/tests/storage_tests.py
94–108	because I'm an idiot who can't use git properly

unrevert round_to_milliseconds changes

Build is green

Patch application report for D3821 (id=13447)

Rebasing onto 3ac332ecbf...

Current branch diff-target is up to date.

Changes applied before test

commit 1aafcf9907f07554e2512680d54227847f46a66f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 15:57:35 2020 +0200

    storage_tests: Remove duplicated postgresql-specific tests.
    
    They got copied to test_postgresql.py instead of moved.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/835/ for more details.

Harbormaster completed remote builds in B14711: Diff 13447.Aug 20 2020, 4:07 PM

Build is green

Patch application report for D3821 (id=13448)

Rebasing onto 3ac332ecbf...

Current branch diff-target is up to date.

Changes applied before test

commit 5390a4cc0aad9182f62e8555db1efecba1f2dbc5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 16:04:30 2020 +0200

    storage_tests: Remove duplicated postgresql-specific tests.
    
    They got copied to test_postgresql.py instead of moved.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/836/ for more details.

Harbormaster completed remote builds in B14712: Diff 13448.Aug 20 2020, 4:11 PM

anlambert accepted this revision.Aug 20 2020, 4:14 PM

This revision is now accepted and ready to land.Aug 20 2020, 4:14 PM

Closed by commit rDSTO5390a4cc0aad: storage_tests: Remove duplicated postgresql-specific tests. (authored by vlorentz). · Explain WhyAug 20 2020, 5:08 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO5390a4cc0aad: storage_tests: Remove duplicated postgresql-specific tests..