Page MenuHomeSoftware Heritage

Rename 'deposit' authority type to 'deposit_client'.
ClosedPublic

Authored by vlorentz on Jul 20 2020, 11:31 AM.

Details

Reviewers
moranegg
ardumont
Group Reviewers
Reviewers
Summary

It makes more sense semantically; as the client is the authority
not the deposit server.

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13771
Build 21104: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 21103: arc lint + arc unit

Event Timeline

vlorentz added a reviewer: moranegg.

Build is green

Patch application report for D3560 (id=12547)

Rebasing onto 7131dcb9cf...

Current branch diff-target is up to date.
Changes applied before test
commit c30c0bf658392298a233d91dbbf818602ccae30a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 20 11:31:30 2020 +0200

    Rename 'deposit' authority type to 'deposit_client'.
    
    It makes more sense semantically; as the client is the authority
    not the deposit server.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/487/ for more details.

also apply required changes to the code.

Build is green

Patch application report for D3560 (id=12548)

Rebasing onto 7131dcb9cf...

Current branch diff-target is up to date.
Changes applied before test
commit 8a982894366b3f35a3fef191090512fbf87ce3b1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 20 11:31:30 2020 +0200

    Rename 'deposit' authority type to 'deposit_client'.
    
    It makes more sense semantically; as the client is the authority
    not the deposit server.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/488/ for more details.

Build has FAILED

Patch application report for D3560 (id=12550)

Rebasing onto 7131dcb9cf...

Current branch diff-target is up to date.
Changes applied before test
commit 95fe0e51198c9f28fc8890d8ff08cae5d5e1131d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 20 11:31:30 2020 +0200

    Rename 'deposit' authority type to 'deposit_client'.
    
    It makes more sense semantically; as the client is the authority
    not the deposit server.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/489/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/489/console

This revision is now accepted and ready to land.Jul 20 2020, 12:32 PM

Build is green

Patch application report for D3560 (id=12550)

Rebasing onto 87b1070b8f...

First, rewinding head to replay your work on top of it...
Applying: Rename 'deposit' authority type to 'deposit_client'.
Changes applied before test
commit 96d9fa64e03ba7c841d4157b529ffaa5a76d4760
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 20 11:31:30 2020 +0200

    Rename 'deposit' authority type to 'deposit_client'.
    
    It makes more sense semantically; as the client is the authority
    not the deposit server.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/492/ for more details.

Closed by 03c6e1552c6496c2eaa764d7d6c64d1b430ec3b5