Rename 'deposit' authority type to 'deposit_client'.
ClosedPublic
Actions

Authored by vlorentz on Jul 20 2020, 11:31 AM.

Details

Reviewers

moranegg
ardumont

Group Reviewers

Reviewers

Summary

It makes more sense semantically; as the client is the authority
not the deposit server.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13773
Build 21108: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21107: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 20 2020, 11:31 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 11:31 AM

add changes to the doc

vlorentz edited the test plan for this revision. (Show Details)Jul 20 2020, 11:35 AM

vlorentz added a reviewer: moranegg.

vlorentz mentioned this in D3561: Rename MetadataAuthorityType.DEPOSIT to MetadataAuthorityType.DEPOSIT_CLIENT..Jul 20 2020, 11:35 AM

Build is green

Patch application report for D3560 (id=12547)

Rebasing onto 7131dcb9cf...

Current branch diff-target is up to date.

Changes applied before test

commit c30c0bf658392298a233d91dbbf818602ccae30a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 20 11:31:30 2020 +0200

    Rename 'deposit' authority type to 'deposit_client'.
    
    It makes more sense semantically; as the client is the authority
    not the deposit server.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/487/ for more details.

Harbormaster completed remote builds in B13770: Diff 12547.Jul 20 2020, 11:38 AM

also apply required changes to the code.

vlorentz added a parent revision: D3561: Rename MetadataAuthorityType.DEPOSIT to MetadataAuthorityType.DEPOSIT_CLIENT..Jul 20 2020, 11:40 AM

vlorentz added a child revision: D3562: Apply renaming of MetadataAuthorityType.DEPOSIT to MetadataAuthorityType.DEPOSIT_CLIENT..Jul 20 2020, 11:40 AM

Build is green

Patch application report for D3560 (id=12548)

Rebasing onto 7131dcb9cf...

Current branch diff-target is up to date.

Changes applied before test

commit 8a982894366b3f35a3fef191090512fbf87ce3b1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 20 11:31:30 2020 +0200

    Rename 'deposit' authority type to 'deposit_client'.
    
    It makes more sense semantically; as the client is the authority
    not the deposit server.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/488/ for more details.

Harbormaster completed remote builds in B13771: Diff 12548.Jul 20 2020, 11:45 AM

Build has FAILED

Patch application report for D3560 (id=12550)

Rebasing onto 7131dcb9cf...

Current branch diff-target is up to date.

Changes applied before test

commit 95fe0e51198c9f28fc8890d8ff08cae5d5e1131d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 20 11:31:30 2020 +0200

    Rename 'deposit' authority type to 'deposit_client'.
    
    It makes more sense semantically; as the client is the authority
    not the deposit server.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/489/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/489/console

Harbormaster failed remote builds in B13773: Diff 12550!Jul 20 2020, 11:46 AM

ardumont accepted this revision.Jul 20 2020, 12:32 PM

This revision is now accepted and ready to land.Jul 20 2020, 12:32 PM

vlorentz mentioned this in rDMOD3b2d72c0bb56: Rename MetadataAuthorityType.DEPOSIT to MetadataAuthorityType.DEPOSIT_CLIENT..Jul 20 2020, 12:45 PM

Build is green

Patch application report for D3560 (id=12550)

Rebasing onto 87b1070b8f...

First, rewinding head to replay your work on top of it...
Applying: Rename 'deposit' authority type to 'deposit_client'.

Changes applied before test

commit 96d9fa64e03ba7c841d4157b529ffaa5a76d4760
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 20 11:31:30 2020 +0200

    Rename 'deposit' authority type to 'deposit_client'.
    
    It makes more sense semantically; as the client is the authority
    not the deposit server.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/492/ for more details.

Harbormaster completed remote builds in B13773: Diff 12550.Jul 20 2020, 12:56 PM

Closed by 03c6e1552c6496c2eaa764d7d6c64d1b430ec3b5

vlorentz closed this revision.Jul 20 2020, 1:00 PM