Page MenuHomeSoftware Heritage

swh.deposit.client: Simplify client xml parsing
ClosedPublic

Authored by ardumont on Jul 20 2018, 4:07 PM.

Details

Summary

This unifies the way we parse xml server side and client side.

Related D396#inline-1961

Diff Detail

Repository
rDDEP Push deposit
Branch
refactor-deposit-client
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1359
Build 1703: arc lint + arc unit

Event Timeline

moranegg added inline comments.
swh/deposit/client/__init__.py
316

Now that I see the namespaces here, it makes me think that we might want to define the properties we are using that are not given by Atom and SWORD to our xml schema (the one we defined in D329 for the sparse and metadata deposit).

This should not be done in this diff, but on a new diff after merging D329, to keep in mind.

349

The properties I'm talking about in the comment above are all the swh properties:

'deposit_swh_id',
'deposit_swh_id_context',
'deposit_swh_anchor_id',
'deposit_swh_anchor_id_context'
This revision is now accepted and ready to land.Jul 23 2018, 11:38 AM
swh/deposit/client/__init__.py
316

You mean define the grammar in a xsd file?

I would do that in yet another diff as this does not exist anywhere though.

This revision was automatically updated to reflect the committed changes.