Differential D396

api/deposit_status: Make swh-id be a directory id derivative
ClosedPublic
Actions

Authored by ardumont on Jul 20 2018, 3:34 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rDDEPb583238de5f8: api/deposit_status: Make swh-id be a directory id derivative

Summary

Adds:

swh-id as directory derivative persistent identifier
swh-id-context the same as swh-id with origin as context in the pid
swh-anchor-id as revision derivative persistent identifier
swh-anchor-id-context the same as swh-anchor-id with origin as context in the pid

Impacts:

deposit status api
private deposit update api
loader
deposit client (returned status endpoint result)

Related T1152

Note that you cannot arc patch locally this diff as the commit parent
is the prior opened diff (D394).

Test Plan

Tests are ok

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 20 2018, 3:34 PM

Harbormaster completed remote builds in B1358: Diff 1235.Jul 20 2018, 3:34 PM

ardumont added inline comments.Jul 20 2018, 3:39 PM

swh/deposit/client/__init__.py
375	I disklike that part. Since the recent changes on the xml parsing, i think we can now merge the way it's done between server and client part (meaning, we could and should use the same code ;). As that has nothing to do with the current diff, I will refactor this in another commit (and diff). That should not be a blocker for that part ;)
swh/deposit/loader/loader.py
112	It's a dict of one key (revision id) and the associated full dict. So here, we solve the id to retrieve further information (directory id) after that. That's the current state of the loader.
swh/deposit/migrations/0014_auto_20180720_1221.py
11	That's why i cannot make a diff starting from master... If i do, when you'll try to 'mount' the db model, that will fail as that does not exist in master (it's another branch)...

ardumont edited the summary of this revision. (Show Details)Jul 20 2018, 3:40 PM

ardumont mentioned this in D397: swh.deposit.client: Simplify client xml parsing.Jul 20 2018, 4:07 PM

ardumont marked an inline comment as done.Jul 20 2018, 5:06 PM

ardumont added inline comments.

swh/deposit/client/__init__.py
375	done in D397

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2018, 11:56 AM

Closed by commit rDDEPb583238de5f8: api/deposit_status: Make swh-id be a directory id derivative (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont marked an inline comment as done.

ardumont mentioned this in rDDEP393fdce06e92: swh.deposit.client: Simplify client parsing.

ardumont mentioned this in D399: deposit/loader: Add missing origin_url transmission step.Jul 23 2018, 12:20 PM

Revision Contents
Changeset List

Path

Size

swh/

deposit/

api/

deposit_status.py

9 lines

private/

deposit_update_status.py

23 lines

client/

32 lines

loader/

24 lines

migrations/

0014_auto_20180720_1221.py

30 lines

3 lines

templates/

deposit/

3 lines

tests/

api/

test_deposit_status.py

18 lines

test_deposit_update_status.py

21 lines

14 lines

loader/

5 lines

Diff 1241

swh/deposit/api/deposit_status.py

Loading...

swh/deposit/api/private/deposit_update_status.py

Loading...

swh/deposit/client/init.py

Loading...

swh/deposit/loader/loader.py

Loading...

swh/deposit/migrations/0014_auto_20180720_1221.py

Loading...

swh/deposit/models.py

Loading...

swh/deposit/templates/deposit/status.xml

Loading...

swh/deposit/tests/api/test_deposit_status.py

Loading...

swh/deposit/tests/api/test_deposit_update_status.py

Loading...

swh/deposit/tests/common.py

Loading...

swh/deposit/tests/loader/common.py

Loading...