Differential D3348

search: Slightly modify search results UI
ClosedPublic
Actions

Authored by anlambert on Jun 24 2020, 4:18 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2320: Simplify display of origin search results

Commits

rDWAPPSe5f80ec6c24c: templates/browse/search: Slightly modify search results UI

Summary

Rename "Visit type" back to "Origin type" as this is more comprehensible for
a user not familiar with SWH data model.

Rename "Visit status" to "Archiving status" and simplify some tooltips for
the same reason.

Wrap some long code lines in origin search related Javascript code.

Closes T2320

Diff Detail

Repository

rDWAPPS Web applications

Branch

search-ui-improvements

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13097
Build 19978: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19977: arc lint + arc unit

Event Timeline

anlambert created this revision.Jun 24 2020, 4:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 24 2020, 4:18 PM

Build is green

Patch application report for D3348 (id=11867)

Rebasing onto 25abbb1cfd...

Current branch diff-target is up to date.

Changes applied before test

commit e82e8a25e397ffa07c55c5e380f6c4b4ca77dc71
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 24 16:16:12 2020 +0200

    templates/browse/search: Slightly modify search results UI
    
    Rename "Visit type" back to "Origin type" as this is more comprehensible for
    a user not familiar with SWH data model.
    
    Rename "Visit status" to "Archiving status" and simplify some tooltips for
    the same reason.
    
    Wrap some long code lines in origin search related Javascript code.
    
    Closes T2320

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/221/ for more details.

Harbormaster completed remote builds in B13082: Diff 11867.Jun 24 2020, 4:27 PM

ardumont accepted this revision.Jun 25 2020, 10:54 AM

This revision is now accepted and ready to land.Jun 25 2020, 10:54 AM

Rebase

Build is green

Patch application report for D3348 (id=11883)

Could not rebase; Attempt merge onto 480f5a8341...

Updating 480f5a83..e5f80ec6
Fast-forward
 cypress/integration/origin-search.spec.js          |  2 +-
 cypress/integration/vault.spec.js                  | 79 ++++++++++++++++++++--
 swh/web/assets/src/bundles/browse/origin-search.js | 27 ++++++--
 .../assets/src/bundles/vault/vault-create-tasks.js | 35 ++++++++--
 swh/web/templates/browse/search.html               |  6 +-
 swh/web/templates/includes/vault-create-tasks.html | 22 ------
 6 files changed, 128 insertions(+), 43 deletions(-)

Changes applied before test

commit e5f80ec6c24c3068ccc07303638fa9e431a443d2
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 24 16:16:12 2020 +0200

    templates/browse/search: Slightly modify search results UI
    
    Rename "Visit type" back to "Origin type" as this is more comprehensible for
    a user not familiar with SWH data model.
    
    Rename "Visit status" to "Archiving status" and simplify some tooltips for
    the same reason.
    
    Wrap some long code lines in origin search related Javascript code.
    
    Closes T2320

commit 48874d558e7d3a7d60ef126c8c4f80edfaf45a28
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 24 14:26:11 2020 +0200

    templates/vault-create-tasks: Improve cooking request submission UX
    
    Instead of visiting the Downloads page each time a cooking request is submitted
    simply display an HTML alert at the botom left of the viewport indicating
    vault task creation success.
    
    Use the same reporting system to display vault service related errors.
    
    Closes T2321

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/223/ for more details.

Harbormaster completed remote builds in B13097: Diff 11883.Jun 25 2020, 11:18 AM

Closed by commit rDWAPPSe5f80ec6c24c: templates/browse/search: Slightly modify search results UI (authored by anlambert). · Explain WhyJun 25 2020, 11:40 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSe5f80ec6c24c: templates/browse/search: Slightly modify search results UI.