Differential D3317

snapshot related views
ClosedPublic
Actions

Authored by anlambert on Jun 18 2020, 6:44 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2326: Improve archived object browsing page design

Commits

rDWAPPS0c7cbf061dfe: templates/browse: Improve navigation for origin/snapshot related views

Summary

Use tabs to navigate between code views, branches list view, releases list view
and origin visits view.

Simplify title in top navbar and move origin links to page main content.

Below are some screenshots of the changes:

Related to T2326

Diff Detail

Repository

rDWAPPS Web applications

Branch

browse-snapshot-ux-improvements

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12947
Build 19724: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19723: arc lint + arc unit

Event Timeline

anlambert created this revision.Jun 18 2020, 6:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 18 2020, 6:44 PM

Build is green

Patch application report for D3317 (id=11737)

Rebasing onto c435bc30e4...

Current branch diff-target is up to date.

Changes applied before test

commit 0c7cbf061dfe88caf0c8ba573817bd5e4f5f18de
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Jun 16 11:42:47 2020 +0200

    templates/browse: Improve navigation for origin/snapshot related views
    
    Use tabs to navigate between code views, branches list view, releases list view
    and origin visits view.
    
    Simplify title in top navbar and move origin links to page main content.
    
    Related to T2326

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/193/ for more details.

Harbormaster completed remote builds in B12947: Diff 11737.Jun 18 2020, 6:55 PM

The screenshots render real nice!

Awesome, can't wait to see it in prod!

Also, looks good to me ;)

This revision is now accepted and ready to land.Jun 18 2020, 6:55 PM

Clean and elegant, LGTM

Closed by commit rDWAPPS0c7cbf061dfe: templates/browse: Improve navigation for origin/snapshot related views (authored by anlambert). · Explain WhyJun 19 2020, 9:54 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS0c7cbf061dfe: templates/browse: Improve navigation for origin/snapshot related views.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

cypress/

integration/

origin-browse.spec.js

87 lines

swh/

web/

assets/

src/

bundles/

browse/

browse-utils.js

16 lines

65%

webapp/

webapp.css

6 lines

common/

utils.py

1 line

87%

templates/

browse/

browse.html

33 lines

origin-visits.html

115 lines

includes/

snapshot-context.html

101 lines

top-navigation.html

4 lines

tests/

browse/

views/

test_content.py

38 lines

99%

test_directory.py

40 lines

95%

test_origin.py

85 lines

98%

test_release.py

29 lines

100%

test_revision.py

45 lines

89%

Diff 11737

View Options

cypress/integration/origin-browse.spec.js

This file was copied to swh/clearlydefined/tests/data/clearydefined_not_mapped.json.

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
},		},
"files": [		"files": [
{		{
"path": "package/LICENSE",		"path": "package/LICENSE",
"hashes": {		"hashes": {
"sha1": "61c2b3a30496d329e21af70dd2d7e097046d07b7",		"sha1": "61c2b3a30496d329e21af70dd2d7e097046d07b7",
"sha256": "8a3c4ecc2f727e1b487daccf186b61457b60a5e1aa7103969fa9b0d8e3ba567b"		"sha256": "8a3c4ecc2f727e1b487daccf186b61457b60a5e1aa7103969fa9b0d8e3ba567b"
}		}
},
{
"path": "package/README.md",
"hashes": {
"sha1": "34973274ccef6ab4dfaaf86599792fa9c3fe4689",
"sha256": "60b9c916c43fba00e2d3ba5207b25bf28109e985c3f739f430bb2056423d5aa9"
}
}		}
],		],
"package.json": {		"package.json": {
"name": "@pixi/mesh-extras",		"name": "@pixi/mesh-extras",
"version": "5.3.5",		"version": "5.3.5",
"main": "lib/mesh-extras.js",		"main": "lib/mesh-extras.js",
"module": "lib/mesh-extras.es.js",		"module": "lib/mesh-extras.es.js",
"bundle": "dist/mesh-extras.js",		"bundle": "dist/mesh-extras.js",
▲ Show 20 Lines • Show All 140 Lines • ▼ Show 20 Lines	"sourceInfo": {
"provider": "github",		"provider": "github",
"namespace": "pixijs",		"namespace": "pixijs",
"name": "pixi.js",		"name": "pixi.js",
"revision": "b5353da2693f0112230cd2b1be581f9bff0ce2a1",		"revision": "b5353da2693f0112230cd2b1be581f9bff0ce2a1",
"url": null,		"url": null,
"path": null		"path": null
}		}
}		}
No newline at end of file		No newline at end of file

View Options

swh/web/assets/src/bundles/browse/browse-utils.js

This file was copied to swh/clearlydefined/tests/data/clearydefined_not_mapped.json.

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
},		},
"files": [		"files": [
{		{
"path": "package/LICENSE",		"path": "package/LICENSE",
"hashes": {		"hashes": {
"sha1": "61c2b3a30496d329e21af70dd2d7e097046d07b7",		"sha1": "61c2b3a30496d329e21af70dd2d7e097046d07b7",
"sha256": "8a3c4ecc2f727e1b487daccf186b61457b60a5e1aa7103969fa9b0d8e3ba567b"		"sha256": "8a3c4ecc2f727e1b487daccf186b61457b60a5e1aa7103969fa9b0d8e3ba567b"
}		}
},
{
"path": "package/README.md",
"hashes": {
"sha1": "34973274ccef6ab4dfaaf86599792fa9c3fe4689",
"sha256": "60b9c916c43fba00e2d3ba5207b25bf28109e985c3f739f430bb2056423d5aa9"
}
}		}
],		],
"package.json": {		"package.json": {
"name": "@pixi/mesh-extras",		"name": "@pixi/mesh-extras",
"version": "5.3.5",		"version": "5.3.5",
"main": "lib/mesh-extras.js",		"main": "lib/mesh-extras.js",
"module": "lib/mesh-extras.es.js",		"module": "lib/mesh-extras.es.js",
"bundle": "dist/mesh-extras.js",		"bundle": "dist/mesh-extras.js",
▲ Show 20 Lines • Show All 140 Lines • ▼ Show 20 Lines	"sourceInfo": {
"provider": "github",		"provider": "github",
"namespace": "pixijs",		"namespace": "pixijs",
"name": "pixi.js",		"name": "pixi.js",
"revision": "b5353da2693f0112230cd2b1be581f9bff0ce2a1",		"revision": "b5353da2693f0112230cd2b1be581f9bff0ce2a1",
"url": null,		"url": null,
"path": null		"path": null
}		}
}		}
No newline at end of file		No newline at end of file

View Options

swh/web/assets/src/bundles/webapp/webapp.css

This file was copied to swh/clearlydefined/tests/data/clearydefined_not_mapped.json.

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
},		},
"files": [		"files": [
{		{
"path": "package/LICENSE",		"path": "package/LICENSE",
"hashes": {		"hashes": {
"sha1": "61c2b3a30496d329e21af70dd2d7e097046d07b7",		"sha1": "61c2b3a30496d329e21af70dd2d7e097046d07b7",
"sha256": "8a3c4ecc2f727e1b487daccf186b61457b60a5e1aa7103969fa9b0d8e3ba567b"		"sha256": "8a3c4ecc2f727e1b487daccf186b61457b60a5e1aa7103969fa9b0d8e3ba567b"
}		}
},
{
"path": "package/README.md",
"hashes": {
"sha1": "34973274ccef6ab4dfaaf86599792fa9c3fe4689",
"sha256": "60b9c916c43fba00e2d3ba5207b25bf28109e985c3f739f430bb2056423d5aa9"
}
}		}
],		],
"package.json": {		"package.json": {
"name": "@pixi/mesh-extras",		"name": "@pixi/mesh-extras",
"version": "5.3.5",		"version": "5.3.5",
"main": "lib/mesh-extras.js",		"main": "lib/mesh-extras.js",
"module": "lib/mesh-extras.es.js",		"module": "lib/mesh-extras.es.js",
"bundle": "dist/mesh-extras.js",		"bundle": "dist/mesh-extras.js",
▲ Show 20 Lines • Show All 140 Lines • ▼ Show 20 Lines	"sourceInfo": {
"provider": "github",		"provider": "github",
"namespace": "pixijs",		"namespace": "pixijs",
"name": "pixi.js",		"name": "pixi.js",
"revision": "b5353da2693f0112230cd2b1be581f9bff0ce2a1",		"revision": "b5353da2693f0112230cd2b1be581f9bff0ce2a1",
"url": null,		"url": null,
"path": null		"path": null
}		}
}		}
No newline at end of file		No newline at end of file

View Options

swh/web/common/utils.py

This file was copied to swh/clearlydefined/tests/data/clearydefined_not_mapped.json.

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
},		},
"files": [		"files": [
{		{
"path": "package/LICENSE",		"path": "package/LICENSE",
"hashes": {		"hashes": {
"sha1": "61c2b3a30496d329e21af70dd2d7e097046d07b7",		"sha1": "61c2b3a30496d329e21af70dd2d7e097046d07b7",
"sha256": "8a3c4ecc2f727e1b487daccf186b61457b60a5e1aa7103969fa9b0d8e3ba567b"		"sha256": "8a3c4ecc2f727e1b487daccf186b61457b60a5e1aa7103969fa9b0d8e3ba567b"
}		}
},
{
"path": "package/README.md",
"hashes": {
"sha1": "34973274ccef6ab4dfaaf86599792fa9c3fe4689",
"sha256": "60b9c916c43fba00e2d3ba5207b25bf28109e985c3f739f430bb2056423d5aa9"
}
}		}
],		],
"package.json": {		"package.json": {
"name": "@pixi/mesh-extras",		"name": "@pixi/mesh-extras",
"version": "5.3.5",		"version": "5.3.5",
"main": "lib/mesh-extras.js",		"main": "lib/mesh-extras.js",
"module": "lib/mesh-extras.es.js",		"module": "lib/mesh-extras.es.js",
"bundle": "dist/mesh-extras.js",		"bundle": "dist/mesh-extras.js",
▲ Show 20 Lines • Show All 140 Lines • ▼ Show 20 Lines	"sourceInfo": {
"provider": "github",		"provider": "github",
"namespace": "pixijs",		"namespace": "pixijs",
"name": "pixi.js",		"name": "pixi.js",
"revision": "b5353da2693f0112230cd2b1be581f9bff0ce2a1",		"revision": "b5353da2693f0112230cd2b1be581f9bff0ce2a1",
"url": null,		"url": null,
"path": null		"path": null
}		}
}		}
No newline at end of file		No newline at end of file