Differential D3169

Pass bytes instead a dict to origin_metadata_add.
ClosedPublic
Actions

Authored by vlorentz on May 19 2020, 6:35 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE6e20b23a593e: Pass bytes instead a dict to origin_metadata_add.

Summary

swh-storage v0.0.191 unexpected allowed a dict under some
circumstances, but it should always be bytes (and v0.0.192
will enforce this).

Test Plan

Tests would start failing when D3168 is landed and released
(ie. v0.0.192)

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12439
Build 18879: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 18878: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 19 2020, 6:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 19 2020, 6:35 PM

vlorentz added a reviewer: ardumont.May 19 2020, 6:36 PM

Yeah!

This closes T2415.

This revision is now accepted and ready to land.May 19 2020, 6:37 PM

Build is green

Patch application report for D3169 (id=11251)

Rebasing onto 1e9b83cdf8...

Current branch diff-target is up to date.

Changes applied before test

commit 6e20b23a593e5ee4f6350d6735f29be6f0ff6255
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 19 18:34:57 2020 +0200

    Pass bytes instead a dict to origin_metadata_add.
    
    swh-storage v0.0.191 unexpected allowed a dict under some
    circumstances, but it should always be bytes (and v0.0.192
    will enforce this).

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/36/ for more details.

Harbormaster completed remote builds in B12439: Diff 11251.May 19 2020, 6:37 PM

Closed by commit rDLDBASE6e20b23a593e: Pass bytes instead a dict to origin_metadata_add. (authored by vlorentz). · Explain WhyMay 19 2020, 6:41 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE6e20b23a593e: Pass bytes instead a dict to origin_metadata_add..