Page MenuHomeSoftware Heritage

Pass bytes instead a dict to origin_metadata_add.
ClosedPublic

Authored by vlorentz on Tue, May 19, 6:35 PM.

Details

Summary

swh-storage v0.0.191 unexpected allowed a dict under some
circumstances, but it should always be bytes (and v0.0.192
will enforce this).

Test Plan

Tests would start failing when D3168 is landed and released
(ie. v0.0.192)

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Tue, May 19, 6:35 PM
ardumont accepted this revision.Tue, May 19, 6:37 PM

Yeah!

This closes T2415.

This revision is now accepted and ready to land.Tue, May 19, 6:37 PM

Build is green

Patch application report for D3169 (id=11251)

Rebasing onto 1e9b83cdf8...

Current branch diff-target is up to date.
Changes applied before test
commit 6e20b23a593e5ee4f6350d6735f29be6f0ff6255
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 19 18:34:57 2020 +0200

    Pass bytes instead a dict to origin_metadata_add.
    
    swh-storage v0.0.191 unexpected allowed a dict under some
    circumstances, but it should always be bytes (and v0.0.192
    will enforce this).

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/36/ for more details.

This revision was automatically updated to reflect the committed changes.