Page MenuHomeSoftware Heritage

origin_metadata_add: Reject non-bytes types for 'metadata'.
ClosedPublic

Authored by vlorentz on Tue, May 19, 6:33 PM.

Details

Summary

The left-over jsonize() allowed passing a dict under some
circumstances, which allowed tests to pass but failed in
production.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Tue, May 19, 6:33 PM
ardumont accepted this revision.Tue, May 19, 6:38 PM

Awesome!

Related to T2415

This revision is now accepted and ready to land.Tue, May 19, 6:38 PM

Build is green

Patch application report for D3168 (id=11250)

Rebasing onto e645e63709...

Current branch diff-target is up to date.
Changes applied before test
commit 8c2ee709495b8c2677f7a60e91075f4c3df75ab3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 19 18:24:21 2020 +0200

    origin_metadata_add: Reject non-bytes types for 'metadata'.
    
    The left-over jsonize() allowed passing a dict under some
    circumstances, which allowed tests to pass but failed in
    production.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/184/ for more details.