Details
- Reviewers
zack - Group Reviewers
Reviewers - Commits
- rDGRPH5d6b06e03979: cli: add a memcache command
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11782 Build 17865: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 17864: arc lint + arc unit
Event Timeline
Build is green
Patch application report for D3002 (id=10664)
Rebasing onto 5cebcba4b5...
Current branch diff-target is up to date.
Changes applied before test
commit 2685dba972d63ffabed627de42b0545ebc2b7a03
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date: Fri Apr 10 12:10:25 2020 +0200
cli: add a memcache commandSee https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/3/ for more details.
Build is green
Patch application report for D3002 (id=10674)
Rebasing onto 5cebcba4b5...
Current branch diff-target is up to date.
Changes applied before test
commit a76740f5a0a199f97a7fc2705978cb92b246d155
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date: Fri Apr 10 12:10:25 2020 +0200
cli: add a memcache commandSee https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/4/ for more details.
Confusing name, I expected this to be a proxy using memcached.
I don't know the file structure of swh-graph, so I'll let someone else (@zack ?) review it
Good point. I also thought of that at first sight.
I guess "shmount" is what this really is?
Other than this, I'm with this change.
| swh/graph/cli.py | ||
|---|---|---|
| 347 | you should mention what the default is (unless click does it for you, which I don't think it's the case) | |
Build has FAILED
Patch application report for D3002 (id=10698)
Rebasing onto 5cebcba4b5...
Current branch diff-target is up to date.
Changes applied before test
commit 5d6b06e039791ecd162b7856ab5e94c687677a4f
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date: Fri Apr 10 12:10:25 2020 +0200
cli: add a memcache commandLink to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/5/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/5/console
Build is green
Patch application report for D3002 (id=10698)
Rebasing onto 5cebcba4b5...
Current branch diff-target is up to date.
Changes applied before test
commit 5d6b06e039791ecd162b7856ab5e94c687677a4f
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date: Fri Apr 10 12:10:25 2020 +0200
cli: add a memcache commandSee https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/6/ for more details.
Build is green
Patch application report for D3002 (id=10698)
Rebasing onto 5cebcba4b5...
Current branch diff-target is up to date.
Changes applied before test
commit 5d6b06e039791ecd162b7856ab5e94c687677a4f
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date: Fri Apr 10 12:10:25 2020 +0200
cli: add a memcache commandSee https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/7/ for more details.