Differential D3002

cli: add a cachemount command
ClosedPublic
Actions

Authored by seirl on Apr 10 2020, 12:19 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Commits

rDGRPH5d6b06e03979: cli: add a memcache command

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seirl created this revision.Apr 10 2020, 12:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 10 2020, 12:19 PM

Build is green

Patch application report for D3002 (id=10664)

Rebasing onto 5cebcba4b5...

Current branch diff-target is up to date.

Changes applied before test

commit 2685dba972d63ffabed627de42b0545ebc2b7a03
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Apr 10 12:10:25 2020 +0200

    cli: add a memcache command

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/3/ for more details.

Harbormaster completed remote builds in B11782: Diff 10664.Apr 10 2020, 12:21 PM

Add default cache path

Build is green

Patch application report for D3002 (id=10674)

Rebasing onto 5cebcba4b5...

Current branch diff-target is up to date.

Changes applied before test

commit a76740f5a0a199f97a7fc2705978cb92b246d155
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Apr 10 12:10:25 2020 +0200

    cli: add a memcache command

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/4/ for more details.

Harbormaster completed remote builds in B11793: Diff 10674.Apr 10 2020, 2:18 PM

Confusing name, I expected this to be a proxy using memcached.

I don't know the file structure of swh-graph, so I'll let someone else (@zack ?) review it

In D3002#72795, @vlorentz wrote:

Confusing name, I expected this to be a proxy using memcached.

Good point. I also thought of that at first sight.

I guess "shmount" is what this really is?

Other than this, I'm with this change.

swh/graph/cli.py
347	you should mention what the default is (unless click does it for you, which I don't think it's the case)

This revision now requires changes to proceed.Apr 10 2020, 4:52 PM

Rename command to cachemount, mention default cache path

Build has FAILED

Patch application report for D3002 (id=10698)

Rebasing onto 5cebcba4b5...

Current branch diff-target is up to date.

Changes applied before test

commit 5d6b06e039791ecd162b7856ab5e94c687677a4f
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Apr 10 12:10:25 2020 +0200

    cli: add a memcache command

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/5/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/5/console

Harbormaster failed remote builds in B11819: Diff 10698!Apr 10 2020, 7:21 PM

Build is green

Patch application report for D3002 (id=10698)

Rebasing onto 5cebcba4b5...

Current branch diff-target is up to date.

Changes applied before test

commit 5d6b06e039791ecd162b7856ab5e94c687677a4f
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Apr 10 12:10:25 2020 +0200

    cli: add a memcache command

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/6/ for more details.

zack retitled this revision from cli: add a memcache command to cli: add a cachemount command.Apr 14 2020, 11:36 AM

Build is green

Patch application report for D3002 (id=10698)

Rebasing onto 5cebcba4b5...

Current branch diff-target is up to date.

Changes applied before test

commit 5d6b06e039791ecd162b7856ab5e94c687677a4f
Author: Antoine Pietri <antoine.pietri1@gmail.com>
Date:   Fri Apr 10 12:10:25 2020 +0200

    cli: add a memcache command

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/7/ for more details.

Harbormaster completed remote builds in B11819: Diff 10698.Apr 14 2020, 11:38 AM

zack accepted this revision.Apr 14 2020, 11:39 AM

This revision is now accepted and ready to land.Apr 14 2020, 11:39 AM

Closed by commit rDGRPH5d6b06e03979: cli: add a memcache command (authored by seirl). · Explain WhyApr 14 2020, 11:41 AM

This revision was automatically updated to reflect the committed changes.

seirl added a commit: rDGRPH5d6b06e03979: cli: add a memcache command.