Details

I don't understand the "runtime validation" comment in the diff description. AFAIK validators from attrs _are_ indeed run when the objects are instantiated (and the documentation seems to back me up).

mypy.ini
4	looks like something that doesn't exist (yet?)
swh/model/model.py
37	Can we get a proper name for this function? something like `attrib_typecheck` would be way more sensible. It'd also be nice to support extra validators to be passed as arguments (though I guess our current attributes with validators are already stricter than a plain typecheck). If we do that then we can have all our attributes use this consistently, I guess.

This revision now requires changes to proceed.Mar 11 2020, 8:01 PM

ardumont added a subscriber: ardumont.Mar 11 2020, 8:02 PM

ardumont added inline comments.

requirements.txt
5	Is it in debian?
swh/model/model.py
600–601	can't you adapt ibv to allow the validator override?

rebase + add missing plugin file

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tox/216/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tox/216/console

Harbormaster failed remote builds in B11089: Diff 10017!Mar 12 2020, 2:31 PM

add support for the 'validator' argument in attrib_typecheck

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tox/217/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tox/217/console

Harbormaster failed remote builds in B11098: Diff 10027!Mar 12 2020, 4:07 PM

douardda added a child revision: D2823: tests: add low level tests for the Timestamp model entity.Mar 12 2020, 4:09 PM

add missing mypy deps in requirements-test

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/220/ for more details.

Harbormaster completed remote builds in B11101: Diff 10030.Mar 12 2020, 4:23 PM

olasd accepted this revision.Mar 16 2020, 2:17 PM

This revision is now accepted and ready to land.Mar 16 2020, 2:17 PM

get rid of the attrib_typecheck() decorator to prevent the need for a mypy plugin

which would then have required to modify the mypy.ini file in every other swh
package.

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/225/ for more details.

Harbormaster completed remote builds in B11350: Diff 10271.Mar 26 2020, 11:30 AM

douardda edited the summary of this revision. (Show Details)Mar 27 2020, 11:06 AM

rebased

Build is green

Patch application report for D2819 (id=10440)

Rebasing onto e9a4c7519e...

Current branch diff-target is up to date.

Changes applied before test

commit 85ca7d7848008951f2e26c55c1c72ed9fa92cefb
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Mar 20 12:59:56 2020 +0100

    model: use attrs_static to enforce type validation of model objects
    
    This ensures all instanciated model entities have valid types for attributes.
    
    Related to T2308.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/18/ for more details.

Harbormaster completed remote builds in B11523: Diff 10440.Apr 1 2020, 10:59 AM

Closed by commit rDMOD85ca7d784800: model: use attrs_static to enforce type validation of model objects (authored by douardda). · Explain WhyApr 1 2020, 2:54 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDMOD85ca7d784800: model: use attrs_static to enforce type validation of model objects.

douardda mentioned this in T2308: Better Validation in swh.model .Apr 1 2020, 3:43 PM