Paths

Table of Contentst

Differential D2814

Extract the dictify() function from BaseModel.to_dict()
ClosedPublic
Actions

Authored by douardda on Mar 11 2020, 5:53 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDMOD0a6d7e050d2c: Extract the dictify() function from BaseModel.to_dict()

Summary

this function does not need to be a local function of the to_dict namespace.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Mar 11 2020, 5:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 11 2020, 5:53 PM

douardda added a child revision: D2815: model: kill Origin.type attribute.Mar 11 2020, 5:54 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/209/ for more details.

Harbormaster completed remote builds in B11077: Diff 10005.Mar 11 2020, 5:54 PM

What about adding tests on this or do you rely on BaseModel's?

ardumont requested changes to this revision.Mar 11 2020, 7:56 PM

This revision now requires changes to proceed.Mar 11 2020, 7:56 PM

In D2814#67371, @ardumont wrote:

What about adding tests on this or do you rely on BaseModel's?

I do rely on nothing, just extracting a function ;-)

Now, I guess swh.model.model tests should be enough to cover this simple helper function. I do not see real value in adding tests here, other than for the sake of unit-ness of said tests.

douardda requested review of this revision.Mar 12 2020, 2:31 PM

ardumont accepted this revision.Mar 12 2020, 2:31 PM

This revision is now accepted and ready to land.Mar 12 2020, 2:31 PM

Closed by commit rDMOD0a6d7e050d2c: Extract the dictify() function from BaseModel.to_dict() (authored by douardda). · Explain WhyMar 12 2020, 2:53 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDMOD0a6d7e050d2c: Extract the dictify() function from BaseModel.to_dict().

Revision Contents
Changeset List

Path

Size

swh/

model/

30 lines

Diff 10020

swh/model/model.py

Loading...