This change generalizes the behavior of loading most revisions and generating a
partial snapshot when we failed to load some of them.
Depends on D2860
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDLDBASE4e66dffab7c1: Make the swh.loader.package exception handling more granular
tox
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- arcpatch-D2860
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11264 Build 17022: tox-on-jenkins Jenkins Build 17021: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/377/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/377/console
Comment Actions
I'm fine with the idea of being more resilient.
Since we want to maximize the ingestion for package loaders.
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/379/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/379/console
Comment Actions
Build on the first iteration:
- make test pass
- add docstring
- call sentry_sdk to push exception to sentry
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/380/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/381/ for more details.
Comment Actions
Remove spurious print statements
| swh/loader/package/loader.py | ||
|---|---|---|
| 15 | I patched the staging node currently running the functional loader. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/382/ for more details.
| swh/loader/package/loader.py | ||
|---|---|---|
| 373 | I guess you can remove the loaded return value now; seems like the function always raises an exception when it fails to load now. This will simplify the caller as well. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/383/ for more details.
| swh/loader/package/loader.py | ||
|---|---|---|
| 355 | I actually don't really like these except Exception statements. I think it would be better to first catch all expected errors, and then fallback on except Exception if it is a unexpected exception (and tag it as unexpected in sentry). For instance, we know some archives will be broken, this would lead to a "expected error". This would allow us to write better tests, since we could test the type of the raised exception. | |
| swh/loader/package/loader.py | ||
|---|---|---|
| 339 | I knew this bothered me for some reason and then it slipped my mind [1] [1] https://sentry.softwareheritage.org/share/issue/c0d1fbfcd865486bb41eea35552f50dd/ status visit can only be ongoing, partial or full... | |