Page MenuHomeSoftware Heritage
Differential D2870

package.loader: Fix status visit to 'partial'
ClosedPublic
Actions

Authored by ardumont on Mar 24 2020, 10:11 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDBASE24b4f3fde2cf: package.loader: Fix status visit to 'partial'
Summary

There is no failed origin visit status in the storage.

Related to https://sentry.softwareheritage.org/share/issue/c0d1fbfcd865486bb41eea35552f50dd/

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 24 2020, 10:11 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 24 2020, 10:11 AM
vlorentz accepted this revision.Mar 24 2020, 10:12 AM
vlorentz added a subscriber: vlorentz.

Needs a test, though

This revision is now accepted and ready to land.Mar 24 2020, 10:12 AM
ardumont added inline comments.Mar 24 2020, 10:12 AM
swh/loader/package/loader.py
344

or we need to amend the storage to allow it..

swh-public-ci added a comment.Mar 24 2020, 10:13 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/386/ for more details.

Harbormaster completed remote builds in B11302: Diff 10226.Mar 24 2020, 10:13 AM
ardumont mentioned this in D2862: Make the swh.loader.package exception handling more granular.Mar 24 2020, 10:17 AM
ardumont updated this revision to Diff 10227.Mar 24 2020, 10:49 AM

i was crafting a test ;)

swh-public-ci added a comment.Mar 24 2020, 10:51 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/387/ for more details.

Harbormaster completed remote builds in B11303: Diff 10227.Mar 24 2020, 10:51 AM
Closed by commit rDLDBASE24b4f3fde2cf: package.loader: Fix status visit to 'partial' (authored by ardumont). · Explain WhyMar 24 2020, 10:54 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDBASE24b4f3fde2cf: package.loader: Fix status visit to 'partial'.

Revision Contents
Changeset List

PathSize
swh/
loader/
package/
2 lines
npm/
tests/
data/
https_replicate.npmjs.com/
20 lines
19 lines

Diff 10228

View Options

swh/loader/package/loader.py

Loading...
View Options

swh/loader/package/npm/tests/data/https_replicate.npmjs.com/catify

Loading...
View Options

swh/loader/package/npm/tests/test_npm.py

Loading...
About · Developer information · Legal