Differential D2846

Detect missing db/cur arguments in 'nested' calls and raise an error.
Changes PlannedPublic
Actions

Authored by vlorentz on Mar 18 2020, 12:42 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

We often forget these (eg. D2845); this diff should prevent most mistakes
in the future.

On the other hand, it's not fool-proof and is a terrible hack...

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

detect-nested-transactions

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11186
Build 16889: tox-on-jenkins	Jenkins
Build 16888: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 18 2020, 12:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 18 2020, 12:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/433/ for more details.

Harbormaster completed remote builds in B11186: Diff 10119.Mar 18 2020, 12:44 PM

use f-string

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/434/ for more details.

Harbormaster completed remote builds in B11187: Diff 10120.Mar 18 2020, 12:46 PM

Inspecting every frame on every call is quite obviously overkill, but this feels like something that we could hook up during tests.

Good idea!

Revision Contents
Changeset List

Path

Size

swh/

core/

db/

common.py

23 lines

tests/

test_db.py

41 lines

Diff 10119

View Options

swh/core/db/common.py