Page MenuHomeSoftware Heritage

Don't nest transactions in content_add/skipped_content_add
ClosedPublic

Authored by olasd on Wed, Mar 18, 12:06 PM.

Details

Summary

Seems like the cur/db arguments have been missed in one of the various
refactorings, creating separate transactions for these function calls.

Test Plan

tox tests unchanged either

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Wed, Mar 18, 12:06 PM
vlorentz accepted this revision.Wed, Mar 18, 12:28 PM
vlorentz added a subscriber: vlorentz.

I have a patch somewhere to detect these oversights, but you might not like it...
Let me find it and open a diff

This revision is now accepted and ready to land.Wed, Mar 18, 12:28 PM
ardumont accepted this revision.Wed, Mar 18, 12:46 PM
This revision was landed with ongoing or failed builds.Wed, Mar 18, 12:52 PM
This revision was automatically updated to reflect the committed changes.