Page MenuHomeSoftware Heritage

Detect missing db/cur arguments in 'nested' calls and raise an error.
Changes PlannedPublic

Authored by vlorentz on Mar 18 2020, 12:42 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

We often forget these (eg. D2845); this diff should prevent most mistakes
in the future.

On the other hand, it's not fool-proof and is a terrible hack...

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
detect-nested-transactions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11186
Build 16889: tox-on-jenkinsJenkins
Build 16888: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 18 2020, 12:42 PM
vlorentz updated this revision to Diff 10120.Mar 18 2020, 12:44 PM

use f-string

olasd added a subscriber: olasd.Mar 18 2020, 2:55 PM

Inspecting every frame on every call is quite obviously overkill, but this feels like something that we could hook up during tests.

vlorentz planned changes to this revision.Mar 18 2020, 3:13 PM

Good idea!