Paths

Table of Contentst

Differential D2838

journal.replay: Align fix revision behavior to other fix methods
ClosedPublic
Actions

Authored by ardumont on Mar 17 2020, 12:09 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDJNLfbd829537b51: journal.replay: Align fix revision behavior to other fix methods

Summary

Fix one revision at a time.
Make it None if unfit for replay.
Logs properly (as in formatted log) a warning about the revision and continue replay.

Test Plan

tox

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 17 2020, 12:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 17 2020, 12:09 PM

ardumont added a child revision: D2839: journal.replay: Inline `_fix_origin_visit` for loop in insert_object.Mar 17 2020, 12:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/400/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/400/console

Harbormaster failed remote builds in B11165: Diff 10097!Mar 17 2020, 12:13 PM

ardumont edited the summary of this revision. (Show Details)Mar 17 2020, 12:14 PM

ardumont added a project: Journal.

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/402/ for more details.

Harbormaster completed remote builds in B11165: Diff 10097.Mar 17 2020, 12:26 PM

Could you also change the _fix_contents I just added?

This revision now requires changes to proceed.Mar 17 2020, 1:58 PM

<ardumont> val: your D2838 comment, sure
<ardumont> but i'd rather do it in another diff if you don't mind

This revision is now accepted and ready to land.Mar 17 2020, 2:01 PM

Rebase on latest master

ardumont mentioned this in D2840: journal.replay: Align _fix_content with other fix methods.Mar 17 2020, 2:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/404/ for more details.

Harbormaster completed remote builds in B11169: Diff 10101.Mar 17 2020, 2:24 PM

Closed by commit rDJNLfbd829537b51: journal.replay: Align fix revision behavior to other fix methods (authored by ardumont). · Explain WhyMar 17 2020, 2:25 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDJNLfbd829537b51: journal.replay: Align fix revision behavior to other fix methods.

ardumont mentioned this in D2879: storage: Refactor internal implementations to use "origin visit update" model representation.Apr 1 2020, 12:12 PM

Revision Contents
Changeset List

Path

Size

swh/

journal/

replay.py

93 lines

Diff 10103

View Options

journal.replay: Align fix revision behavior to other fix methodsClosedPublicActions