Page MenuHomeSoftware Heritage

journal.replay: Align fix revision behavior to other fix methods
ClosedPublic

Authored by ardumont on Mar 17 2020, 12:09 PM.

Details

Summary
  • Fix one revision at a time.
  • Make it None if unfit for replay.
  • Logs properly (as in formatted log) a warning about the revision and continue replay.
Test Plan

tox

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11169
Build 16863: tox-on-jenkinsJenkins
Build 16862: arc lint + arc unit

Event Timeline

ardumont added a project: Journal.
vlorentz added a subscriber: vlorentz.

Could you also change the _fix_contents I just added?

This revision now requires changes to proceed.Mar 17 2020, 1:58 PM
<ardumont> val: your D2838 comment, sure
<ardumont> but i'd rather do it in another diff if you don't mind
This revision is now accepted and ready to land.Mar 17 2020, 2:01 PM