Page MenuHomeSoftware Heritage

journal.replay: Align fix revision behavior to other fix methods
ClosedPublic

Authored by ardumont on Tue, Mar 17, 12:09 PM.

Details

Summary
  • Fix one revision at a time.
  • Make it None if unfit for replay.
  • Logs properly (as in formatted log) a warning about the revision and continue replay.
Test Plan

tox

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Tue, Mar 17, 12:09 PM
ardumont edited the summary of this revision. (Show Details)Tue, Mar 17, 12:14 PM
ardumont added a project: Journal.
vlorentz requested changes to this revision.Tue, Mar 17, 1:58 PM
vlorentz added a subscriber: vlorentz.

Could you also change the _fix_contents I just added?

This revision now requires changes to proceed.Tue, Mar 17, 1:58 PM
vlorentz accepted this revision.Tue, Mar 17, 2:01 PM
<ardumont> val: your D2838 comment, sure
<ardumont> but i'd rather do it in another diff if you don't mind
This revision is now accepted and ready to land.Tue, Mar 17, 2:01 PM
ardumont updated this revision to Diff 10101.Tue, Mar 17, 2:20 PM

Rebase on latest master