Stylistically, I'm really not sure about the inconsistent replacement of hash_to_bytes calls, with a shorthand that we've never used anywhere else. And the bhex name doesn't look very meaningful (frankly, if we're going there, I'd rather have it called b()).

This revision now requires changes to proceed.Mar 11 2020, 8:06 PM

replace bhex() by _x() and other stuff reported by olasd

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/215/ for more details.

Harbormaster completed remote builds in B11088: Diff 10016.Mar 12 2020, 2:30 PM

I still think the id bytes / hex string inconsistency for releases, revisions, directories and contents should be fixed, but I think this short-hand notation looks decent.

This revision is now accepted and ready to land.Mar 12 2020, 2:33 PM

Closed by commit rDMOD97af8866ebaf: tests/identifiers: fix 'target', 'directory' and 'parents' object types (authored by douardda). · Explain WhyMar 12 2020, 2:53 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDMOD97af8866ebaf: tests/identifiers: fix 'target', 'directory' and 'parents' object types.