Page MenuHomeSoftware Heritage
Create Task
Maniphest T4280

Unstuck swh-web master build failing
Closed, MigratedEdits Locked
Actions

Description

Mypy is not happy and fails the master build.
That prevents new release.

[1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3135/console

Revisions and Commits

rDWAPPS Web applications
AbandonedD7895 wip: Fix mypy issues which fail the master build
rDAUTH Common authentication libraries
D7901rDAUTHcf6397a0ef5f Add support for python-keycloak >= 1.0.0

Related Objects

Event Timeline

ardumont triaged this task as High priority.May 25 2022, 5:59 PM
ardumont created this task.

Tentatively tried it but that's not working [1]

[1] D7895

ardumont added a revision: D7895: wip: Fix mypy issues which fail the master build.May 25 2022, 6:00 PM
ardumont updated the task description. (Show Details)

That currently prevented the v0.0.391 from being built [1].

I currently deactivated the mypy stage and triggered back that build (cheat) so that release can happen.
The real fix should happen in the webapp repository but it's too late and my brain refuses to find the actual problem so ¯\_(ツ)_/¯.

[1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/

ardumont added a comment.EditedMay 25 2022, 6:36 PM

computer says no [1]

nice try though (or so i think) !

[1] https://jenkins.softwareheritage.org/job/DWAPPS/job/tests/3137/console

vlorentz added a revision: D7901: Add support for python-keycloak >= 1.0.0.May 30 2022, 1:37 PM
vlorentz added a commit: rDAUTHcf6397a0ef5f: Add support for python-keycloak >= 1.0.0.May 30 2022, 2:07 PM
ardumont added a subscriber: vlorentz.May 30 2022, 5:38 PM

Build is back to green thanks to you @vlorentz.

We can close it now.

ardumont closed this task as Resolved.May 30 2022, 5:47 PM
ardumont claimed this task.

Thanks again!

gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:37 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal