Page MenuHomeSoftware Heritage
Differential D7895

wip: Fix mypy issues which fail the master build
AbandonedPublicDraft
Actions

Authored by ardumont on May 25 2022, 3:25 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T4280: Unstuck swh-web master build failing
Summary

As per [1]

[1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3135/console

Related to T4280

Test Plan

did not check tox, let's see what jenkins say

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29578
Build 46223: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 46222: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
0 msJenkins > "before all" hook for "should load add forge request details"::Tests / Cypress tests / Run cypress tests / Test add forge now request dashboard load "before all" hook for "should load add forge request details"
CypressError: `cy.request()` failed on: http://localhost:5004/admin/login/
1,090 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_views::Tests / Python tests / test_add_forge_request_list_datatables
client = <django.test.client.Client object at 0x7f45e55ecb70> regular_user = <User: johndoe>, regular_user2 = <User: janedoe> add_forge_moderator = <User: add-forge moderator>
1,036 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_views::Tests / Python tests / test_add_forge_request_list_datatables_no_parameters
client = <django.test.client.Client object at 0x7f45e4e0bc50> regular_user = <User: johndoe>, regular_user2 = <User: janedoe>
930 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_views::Tests / Python tests / test_add_forge_request_list_datatables_ordering
client = <django.test.client.Client object at 0x7f45e53d9550> regular_user = <User: johndoe>, regular_user2 = <User: janedoe>
1,004 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_views::Tests / Python tests / test_add_forge_request_list_datatables_search
client = <django.test.client.Client object at 0x7f45e4325470> regular_user = <User: johndoe>, regular_user2 = <User: janedoe>
View Full Test Results (350 Failed · 652 Passed · 5 Skipped)

Event Timeline

ardumont created this revision.May 25 2022, 3:25 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 25 2022, 3:25 PM
swh-public-ci added a comment.May 25 2022, 3:26 PM

Build has FAILED

Patch application report for D7895 (id=28478)

Rebasing onto a3529323b9...

Current branch diff-target is up to date.
Changes applied before test
commit 6345e756b33b61ad1b8545524120980d808468ec
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 25 15:01:40 2022 +0200

    Fix mypy issues which fail the master build
    
    As per [1]
    
    [1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3135/console

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1858/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1858/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2022, 3:26 PM
Harbormaster failed remote builds in B29568: Diff 28478!
ardumont updated this revision to Diff 28483.EditedMay 25 2022, 3:39 PM

Build has failed

15:26:34  ./swh/web/tests/browse/views/test_snapshot.py:87:5: F821 undefined name 'iso8601'

/me *sighs*
Replicate iso8601 requirement for tests that somehow is missing hence failing the build...

swh-public-ci added a comment.May 25 2022, 3:40 PM

Build has FAILED

Patch application report for D7895 (id=28483)

Rebasing onto a3529323b9...

Current branch diff-target is up to date.
Changes applied before test
commit 48df349ac65ea79dc9f4bcb65fb712bc14f995c9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 25 15:01:40 2022 +0200

    Fix mypy issues which fail the master build
    
    As per [1]
    
    [1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3135/console

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1859/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1859/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2022, 3:41 PM
Harbormaster failed remote builds in B29573: Diff 28483!
ardumont added a comment.May 25 2022, 4:17 PM

Build has failed

15:26:34  ./swh/web/tests/browse/views/test_snapshot.py:87:5: F821 undefined name 'iso8601'

*ugh*, i don't get it... (well i did not before as well but...)

ardumont updated this revision to Diff 28488.May 25 2022, 4:19 PM

Fix flake8 dummyness

swh-public-ci added a comment.May 25 2022, 4:46 PM

Build has FAILED

Patch application report for D7895 (id=28488)

Rebasing onto a3529323b9...

Current branch diff-target is up to date.
Changes applied before test
commit 7da409677700c0903b6e698da8248cdffb42a7e9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 25 15:01:40 2022 +0200

    Fix mypy issues which fail the master build
    
    As per [1]
    
    [1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3135/console

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1860/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1860/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 25 2022, 4:46 PM
Harbormaster failed remote builds in B29578: Diff 28488!
ardumont added a comment.May 25 2022, 5:36 PM

Probably not the right way to fix it ¯\_(ツ)_/¯
Deps diff to ease with that maybe [1]

[1] https://forge.softwareheritage.org/P1367

ardumont mentioned this in T4280: Unstuck swh-web master build failing .May 25 2022, 6:00 PM
ardumont edited the summary of this revision. (Show Details)
ardumont added a task: T4280: Unstuck swh-web master build failing .
ardumont retitled this revision from Fix mypy issues which fail the master build to wip: Fix mypy issues which fail the master build.May 25 2022, 6:03 PM
vlorentz added a subscriber: vlorentz.May 30 2022, 1:42 PM

last build failure does not seem to be related to iso8601, it's an "assert isinstance(...)" failurez

swh/web/tests/browse/views/test_snapshot.py
87

?

ardumont abandoned this revision.May 30 2022, 5:38 PM

Revision Contents
Changeset List

PathSize
1 line
swh/
web/
common/
18 lines
15 lines
tests/
browse/
views/
7 lines
2 lines
32 lines

Diff 28488

View Options

requirements-test.txt

Loading...
View Options

swh/web/common/identifiers.py

Loading...
View Options

swh/web/common/utils.py

Loading...
View Options

swh/web/tests/browse/views/test_snapshot.py

Loading...
View Options

swh/web/tests/conftest.py

Loading...
View Options

swh/web/tests/utils.py

Loading...
About · Developer information · Legal