Page MenuHomeSoftware Heritage

Make loaders pass ExtId objects between functions instead of "known_artifact"
Closed, ResolvedPublic

Description

known_artifacts is an untyped dict passed around the package loaders and loaded from the 'revisions.metadata' column.

AFAICT, it is only ever used to read one value at the end of its journey through the loader.

Instead, this dict should be converted to an ExtId object as soon as possible.

Note that this task isn't about using the extid storage, but is a transitional state we need to smoothly start using the extid storage

Event Timeline

vlorentz triaged this task as Normal priority.Mar 16 2021, 12:22 PM
vlorentz created this task.

actually, only solved for package loaders

now it is. (the mercurial loader technically doesn't use ExtID internally, but it already passes nodeids, which are close enough)