Improve date parsing error messages

Closed, MigratedEdits Locked

Actions

From discussion with @ardumont, this is only about the utils.py parse_timestamp function, to receive date inputs from users.

We have python3-dateutil version 2.4.2, which constructs the result from defaults even if nothing in the string matched - this means that we can't differentiate a request for the default and a parser failure. Version 2.5.0 fixes this to return a ValueError if the parsing fails.

Additionally, while attempting to see if the input is a POSIX timestamp in case of failure, we should also catch a conversion error and return an exception with a more verbose/descriptive message.

This function was rewritten, its actual behavior no longer matches what's described by @jbertran, that is:

• if the timestamp is None, return None directly (it's up to the caller to do something appropriate with that)
• Otherwise, try to parse it, if successful, returns the resulting datetime
• Otherwise, assume the date passed is a timestamp and try to determine the date from that, if ok, return the datetime
• Otherwise, throws a BadInputExc with the original error (which renders a 400, bad request to the api caller).