Page MenuHomeSoftware Heritage

Improve handling of file names with special characters
Closed, ResolvedPublic

Description

Filenames with special characters (like ;) are not properly handled by the WebApp.

To see the problem, browse this directory and try to click on the files with the following file names

;url=foo
x;url=foo

We spotted this while working on T1241 with @vlorentz; it seems that the percent-escaping of the ; and % characters should suffice, and is also needed for implementing the new PID spec from T1241

Event Timeline

rdicosmo created this task.Mar 30 2020, 4:56 PM

I do not encounter any particular issue when trying to browse these files. Their content is equal to their filename so the confusion I think.

Nevertheless, paths and urls will indeed need to be escaped in PIDS as we will have some parsing issues otherwise.

rdicosmo closed this task as Resolved.Mar 30 2020, 5:15 PM

Oh, sorry for the noise...