Maniphest T2286

Use proper URL building in origin-search.js
Closed, MigratedEdits Locked
Actions

Assigned To

gitlab-migration

Authored By

	vlorentz
	Feb 14 2020, 4:00 PM

Tags

Subscribers

gitlab-migration

Description

Currently, we do it by appending fragments of strings and manually escaping data, which isn't ideal. URL and URLSearchParams should be used instead.

Revisions and Commits

rDWAPPS Web applications
	D2707	rDWAPPS36b589f9337f browse/origin-search: To Use proper URL building in origin-search.js

Related Objects

Mentioned In: D2707: To Use proper URL building in origin-search.js

Event Timeline

vlorentz triaged this task as Low priority.Feb 14 2020, 4:00 PM

vlorentz created this task.

anlambert updated the task description. (Show Details)Feb 18 2020, 5:17 PM

Can I get more details about this task?

anlambert updated the task description. (Show Details)Feb 20 2020, 11:23 AM

In T2286#42105, @Iamshankhadeep wrote:

Can I get more details about this task?

Dedicated JavaScript interfaces must be used to build search URLs instead of manually building them (see https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/assets/src/bundles/browse/origin-search.js$179-188 and https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/assets/src/bundles/browse/origin-search.js$89-98)

anlambert updated the task description. (Show Details)Feb 20 2020, 11:35 AM

Iamshankhadeep mentioned this in D2707: To Use proper URL building in origin-search.js.Feb 21 2020, 4:30 PM

Iamshankhadeep closed this task as Resolved by committing rDWAPPS36b589f9337f: browse/origin-search: To Use proper URL building in origin-search.js.Feb 22 2020, 3:38 PM

Iamshankhadeep claimed this task.

Iamshankhadeep added a commit: rDWAPPS36b589f9337f: browse/origin-search: To Use proper URL building in origin-search.js.

This task has been migrated to GitLab.