Page MenuHomeSoftware Heritage
Create Task
Maniphest T166

functional tests for the web UI, with actual data
Closed, MigratedEdits Locked
Actions

Description

We don't really have functional test for the Web UI right now, we only test some of its units.
We should add proper end-to-end functional tests.

To do so we need to

  1. either, augment storage-testdata with actual data and deploy a storage backend when running the web UI testsuite,
  2. or, use object mocking to simulate the existence of the storage backend

Related Objects

Event Timeline

zack created this task.Oct 28 2015, 7:01 PM
zack raised the priority of this task from to Normal.
zack updated the task description. (Show Details)
zack added projects: Web app, Developers.
Herald added a project: Staff. · View Herald TranscriptOct 28 2015, 7:01 PM
zack added a subscriber: zack.Oct 28 2015, 7:01 PM

FWIW, my preference is for (2), i.e., object mocking.

ardumont claimed this task.Nov 9 2015, 4:53 PM
ardumont raised the priority of this task from Normal to High.
ardumont added a comment.EditedNov 13 2015, 2:55 PM

swh-web-ui is now using mocks (standard lib in python3 - unittest.mock).

It's not end-to-end tests yet.
Still, the coverage has improved from api (controller.py) to service modules (service.py).

(The part not well covered for the moment are the generated html pages)

ardumont lowered the priority of this task from High to Normal.Nov 13 2015, 2:56 PM
ardumont removed ardumont as the assignee of this task.Nov 25 2015, 3:34 PM
ardumont added a subscriber: ardumont.Dec 3 2015, 11:37 AM

Since T223, controller has been split in 2 and both api and views (T224) are covered the unit test way.

ardumont added a comment.Dec 3 2015, 12:34 PM

State on swh-web-ui coverage:

Name Stmts Miss Cover Missing

swh.web.ui 0 0 100%
swh.web.ui.api 59 3 95% 29, 41, 275
swh.web.ui.converters 36 1 97% 13
swh.web.ui.errorhandler 7 0 100%
swh.web.ui.exc 6 0 100%
swh.web.ui.main 48 33 31% 38-48, 64-69, 75-89, 110-128
swh.web.ui.query 27 3 89% 44, 48, 57
swh.web.ui.renderers 44 0 100%
swh.web.ui.service 80 5 94% 121, 154, 172, 178, 215
swh.web.ui.upload 29 0 100%
swh.web.ui.utils 32 0 100%

swh.web.ui.views 91 2 98% 27-30

TOTAL 459 47 90%

Ran 101 tests in 0.405s

OK

ardumont closed this task as Resolved.Jan 18 2016, 4:08 PM
zack removed projects: Developers, Staff.Mar 10 2016, 5:52 PM
olasd changed the visibility from "All Users" to "Public (No Login Required)".May 13 2016, 5:07 PM
gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 4:17 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal