Page MenuHomeSoftware Heritage

Web UI: origins returning 505: 'NoneType' object has no attribute 'split'
Closed, ResolvedPublic

Description

A number of origins fail to be rendered with HTTP response 505 and the message in title.

An example is https://archive.softwareheritage.org/browse/origin/https://github.com/WilsonSayresLab/Anole_expression/directory/

A longer list with ~200 origins is at

Event Timeline

zack created this task.Oct 31 2018, 11:08 AM
zack triaged this task as High priority.
zack updated the task description. (Show Details)

After a quick analysis, this seems related to origins with a partial visit and no captured snapshot, see http://archive.softwareheritage.org/api/1/origin/git/url/https://github.com/WilsonSayresLab/Anole_expression

An exception should be thrown somewhere to handle these cases.

zack added a comment.Oct 31 2018, 11:25 AM

Right.

To elaborate, the user-visible result should be the same of origins that haven't been visited yet, e.g.:

which returns 404 and a user-targeted error message.

zack added a comment.EditedOct 31 2018, 11:25 AM

(I also note that the search results page treat both cases similarly: showing an X for both kind of origins. Good!)