Page MenuHomeSoftware Heritage
Differential D991

Kill the DiskIndexer mixin class in favor of a simple contextmanager
ClosedPublic
Actions

Authored by douardda on Jan 24 2019, 9:29 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDXbf74c722ccb4: Kill the DiskIndexer mixin class in favor of a simple contextmanager
Summary

This needs a slight mofdification in the tests (ctags and fossology), since
killing DiskIndexer means killing also NoDiskIndexer...

Depends on D990

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 24 2019, 9:29 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 24 2019, 9:29 AM
Harbormaster failed remote builds in B3662: Diff 3137!Jan 24 2019, 9:32 AM
swh-public-ci added a subscriber: swh-public-ci.Jan 24 2019, 9:32 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/252/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/252/console

ardumont accepted this revision.Jan 24 2019, 9:44 AM
This revision is now accepted and ready to land.Jan 24 2019, 9:44 AM
douardda updated this revision to Diff 3140.Jan 24 2019, 10:11 AM

Rebased

Closed by commit rDCIDXbf74c722ccb4: Kill the DiskIndexer mixin class in favor of a simple contextmanager (authored by douardda). · Explain WhyJan 24 2019, 10:12 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B3665: Diff 3140!Jan 24 2019, 10:14 AM
swh-public-ci added a comment.Jan 24 2019, 10:14 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/254/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/254/console

Revision Contents
Changeset List

PathSize
swh/
indexer/
23 lines
18 lines
54 lines
tests/
8 lines
14 lines
13 lines

Diff 3142

View Options

swh/indexer/ctags.py

Loading...
View Options

swh/indexer/fossology_license.py

Loading...
View Options

swh/indexer/indexer.py

Loading...
View Options

swh/indexer/tests/test_ctags.py

Loading...
View Options

swh/indexer/tests/test_fossology_license.py

Loading...
View Options

swh/indexer/tests/utils.py

Loading...
About · Developer information · Legal