Fix bitbucker lister: min_bound must be a date
ClosedPublic
Actions

Authored by douardda on Jan 14 2019, 12:13 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLS028ceca90d72: Fix bitbucker lister: request_uri expect 'identifier' to be a date

Summary

which it won't be when the lister is called for the first time (will be
None in this case).

Depends on D938

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 14 2019, 12:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 14 2019, 12:13 PM

douardda added a child revision: D940: Fix SWHIndexingLister.db_partition_indices(); ensure partition size is not zero.Jan 14 2019, 12:13 PM

Harbormaster failed remote builds in B3462: Diff 2966!Jan 14 2019, 12:13 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/47/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/47/console

Another way is to override request_uri:

def request_uri(self, identifier):
    return super().request_uri(identifier or '1970-01-01')

This revision is now accepted and ready to land.Jan 14 2019, 1:16 PM

In D939#20033, @vlorentz wrote:
Another way is to override request_uri:
def request_uri(self, identifier):
    return super().request_uri(identifier or '1970-01-01')

I guess this solution makes sense indeed

follow vlorentz' advice: overload the request_uri method

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/51/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/51/console

Harbormaster failed remote builds in B3505: Diff 3003!Jan 15 2019, 3:34 PM

Closed by commit rDLS028ceca90d72: Fix bitbucker lister: request_uri expect 'identifier' to be a date (authored by douardda). · Explain WhyJan 15 2019, 4:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

bitbucket/

lister.py

3 lines

Diff 3011

View Options

swh/lister/bitbucket/lister.py

Fix bitbucker lister: min_bound must be a dateClosedPublicActions