Page MenuHomeSoftware Heritage

Add a new 'task-type add' command
ClosedPublic

Authored by douardda on Jan 14 2019, 11:40 AM.

Details

Summary

3 revisions

  • Add a new task-type cli command group and move the task_type listing in there
  • Make SchedulerBackend.create_task_type work with only a subset of keys

    Not all keys are mandatory, so do not expect all the possible keys for the task_type table to be given when calling create_task_type().

    Note: no validation is made whether the given set of keys fullfill the table constraints.
  • Add the 'task-type add' cli command

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
wip
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 3450
Build 4449: tox-on-jenkinsJenkins
Build 4448: arc lint + arc unit

Event Timeline

ardumont added a subscriber: ardumont.

Nice!

swh/scheduler/backend.py
229

Isn't it better to create the list of keys to use once and reuse it in both places?

This revision is now accepted and ready to land.Jan 14 2019, 11:50 AM
douardda added inline comments.
swh/scheduler/backend.py
229

I was expecting someone to complain about it ;-)

Fullfill ardumont's expectations!

Fix a bug introduced in create_task_type (since task_type[key] != key !!)

This revision was automatically updated to reflect the committed changes.