Differential D932

Add a new 'task-type add' command
ClosedPublic
Actions

Authored by douardda on Jan 14 2019, 11:40 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSCH2dbdb6ccb5d2: Add a new 'task-type add' cli command
rDSCHc3bb48d9c5ee: Make SchedulerBackend.create_task_type work with only a subset of keys
rDSCH4c753305e930: Add a new task-type cli command group and move the task_type listing in there

Summary

3 revisions

Add a new task-type cli command group and move the task_type listing in there

Make SchedulerBackend.create_task_type work with only a subset of keys

Not all keys are mandatory, so do not expect all the possible keys for the task_type table to be given when calling create_task_type().

Note: no validation is made whether the given set of keys fullfill the table constraints.

Add the 'task-type add' cli command

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 14 2019, 11:40 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 14 2019, 11:40 AM

Harbormaster failed remote builds in B3450: Diff 2956!Jan 14 2019, 11:40 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/81/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/81/console

douardda added a child revision: D934: Add a new 'task list' cli command.Jan 14 2019, 11:43 AM

Nice!

swh/scheduler/backend.py
229 ↗	(On Diff #2956)	Isn't it better to create the list of keys to use once and reuse it in both places?

This revision is now accepted and ready to land.Jan 14 2019, 11:50 AM

douardda marked an inline comment as done.Jan 14 2019, 3:17 PM

douardda added inline comments.

swh/scheduler/backend.py
229 ↗	(On Diff #2956)	I was expecting someone to complain about it ;-)

Fullfill ardumont's expectations!

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/86/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/86/console

Harbormaster failed remote builds in B3469: Diff 2973!Jan 14 2019, 3:24 PM

Fix a bug introduced in create_task_type (since task_type[key] != key !!)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/92/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/92/console

Harbormaster failed remote builds in B3476: Diff 2980!Jan 15 2019, 10:35 AM

Closed by commit rDSCH4c753305e930: Add a new task-type cli command group and move the task_type listing in there (authored by douardda). · Explain WhyJan 15 2019, 3:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

46 lines

Diff 2991

swh/scheduler/cli.py

Loading...