Page MenuHomeSoftware Heritage

Add a new 'task-type add' command
ClosedPublic

Authored by douardda on Jan 14 2019, 11:40 AM.

Details

Summary

3 revisions

  • Add a new task-type cli command group and move the task_type listing in there
  • Make SchedulerBackend.create_task_type work with only a subset of keys

    Not all keys are mandatory, so do not expect all the possible keys for the task_type table to be given when calling create_task_type().

    Note: no validation is made whether the given set of keys fullfill the table constraints.
  • Add the 'task-type add' cli command

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 14 2019, 11:40 AM
ardumont accepted this revision.Jan 14 2019, 11:50 AM
ardumont added a subscriber: ardumont.

Nice!

swh/scheduler/backend.py
229 ↗(On Diff #2956)

Isn't it better to create the list of keys to use once and reuse it in both places?

This revision is now accepted and ready to land.Jan 14 2019, 11:50 AM
douardda marked an inline comment as done.Jan 14 2019, 3:17 PM
douardda added inline comments.
swh/scheduler/backend.py
229 ↗(On Diff #2956)

I was expecting someone to complain about it ;-)

douardda updated this revision to Diff 2973.Jan 14 2019, 3:21 PM

Fullfill ardumont's expectations!

douardda updated this revision to Diff 2980.Jan 15 2019, 10:32 AM

Fix a bug introduced in create_task_type (since task_type[key] != key !!)

This revision was automatically updated to reflect the committed changes.