loader: Compute contents diff when detecting trees divergence
ClosedPublic
Actions

Authored by anlambert on Dec 5 2022, 1:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN2b80484b8b70: loader: Compute contents diff when detecting trees divergence

Summary

In debug mode, when a hash tree computation divergence is detected after
replaying a revision, compute and display the diff between contents to
facilitate debugging of those type of issues.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 5 2022, 1:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 5 2022, 1:33 PM

Build is green

Patch application report for D8913 (id=32121)

Rebasing onto e35f800a42...

Current branch diff-target is up to date.

Changes applied before test

commit 2b80484b8b70ce9cdc5d5b8fc607c97e44667862
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 5 13:28:53 2022 +0100

    loader: Compute contents diff when detecting trees divergence
    
    In debug mode, when a hash tree computation divergence is detected after
    replaying a revision, compute and display the diff between contents to
    facilitate debugging of those type of issues.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/360/ for more details.

Harbormaster completed remote builds in B33074: Diff 32121.Dec 5 2022, 1:36 PM

anlambert requested review of this revision.Dec 5 2022, 1:36 PM

Good idea but you need to update that conditional.

swh/loader/svn/loader.py
335	Given the following instructions seem expensive (svn export, diff computation, ...) you probably want to check the logging level against debug too (in the conditional). Otherwise, you the diff computation ends up being unused.