Differential D8867

save_origin_webhooks: Handle github ping event
ClosedPublic
Actions

Authored by anlambert on Nov 21 2022, 4:46 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook

Commits

rDWAPPS84922dfd698b: save_origin_webhooks: Handle github ping event

Summary

Previously, github webhook receiver was returning a 400 HTTP error code
for a ping event which can be confusing for users so ensure to return
a 200 HTTP code.

Related to T4548

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 21 2022, 4:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 21 2022, 4:46 PM

Build has FAILED

Patch application report for D8867 (id=31959)

Rebasing onto 01e50d60cd...

Current branch diff-target is up to date.

Changes applied before test

commit 84922dfd698b65eceaaedf2fc3cbfeccc792f728
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 21 15:42:17 2022 +0100

    save_origin_webhooks: Handle github ping event
    
    Previously, github webhook receiver was returning a 400 HTTP error code
    for a ping event which can be confusing for users so ensure to return
    a 200 HTTP code.
    
    Related to T4548

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2156/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2156/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 21 2022, 4:58 PM

Harbormaster failed remote builds in B32888: Diff 31959!

Build is green

Patch application report for D8867 (id=31959)

Rebasing onto 01e50d60cd...

Current branch diff-target is up to date.

Changes applied before test

commit 84922dfd698b65eceaaedf2fc3cbfeccc792f728
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 21 15:42:17 2022 +0100

    save_origin_webhooks: Handle github ping event
    
    Previously, github webhook receiver was returning a 400 HTTP error code
    for a ping event which can be confusing for users so ensure to return
    a 200 HTTP code.
    
    Related to T4548

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2157/ for more details.

Harbormaster completed remote builds in B32888: Diff 31959.Nov 21 2022, 5:28 PM

anlambert requested review of this revision.Nov 21 2022, 5:28 PM

anlambert added a child revision: D8868: save_origin_webhooks: Handle private repositories.Nov 21 2022, 5:40 PM

vlorentz accepted this revision.Nov 21 2022, 7:07 PM

This revision is now accepted and ready to land.Nov 21 2022, 7:07 PM

Closed by commit rDWAPPS84922dfd698b: save_origin_webhooks: Handle github ping event (authored by anlambert). · Explain WhyNov 22 2022, 10:39 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS84922dfd698b: save_origin_webhooks: Handle github ping event.