Differential D8841

save_code_now: Allow request creation if previous for origin is running
ClosedPublic
Actions

Authored by anlambert on Nov 14 2022, 5:27 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook

Commits

rDWAPPSab849109ea1d: save_code_now: Allow request creation if previous for origin is running

Summary

Previously, the save code now service was not allowing to create a new
request for an origin if a previously created one for the same origin
was currently running.

However, new commits might have been pushed to the origin while a loading
task is running so this restriction does not make sense, especially for
the new forge webhook receivers feature.

Related to T4548

Diff Detail

Repository

rDWAPPS Web applications

Branch

save-code-now-create-new-request-if-previous-running

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32792
Build 51378: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51377: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 14 2022, 5:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 14 2022, 5:27 PM

Build is green

Patch application report for D8841 (id=31856)

Rebasing onto ad8558c69d...

Current branch diff-target is up to date.

Changes applied before test

commit de0d5cfdea3d52f60ac60ab6f6434a72c7f3881c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 14 17:21:26 2022 +0100

    save_code_now: Allow request creation if previous for origin is running
    
    Previously, the save code now service was not allowing to create a new
    request for an origin if a previously created one for the same origin
    was currently running.
    
    However, new commits might have been pushed to the origin while a loading
    task is running so this restriction does not make sense, especially for
    the new forge webhook receivers feature.
    
    Related to T4548

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2131/ for more details.

Harbormaster completed remote builds in B32792: Diff 31856.Nov 14 2022, 5:35 PM

anlambert requested review of this revision.Nov 14 2022, 5:35 PM

ardumont accepted this revision.Nov 16 2022, 2:56 PM

This revision is now accepted and ready to land.Nov 16 2022, 2:56 PM

Rebase

Build is green

Patch application report for D8841 (id=31900)

Rebasing onto 694802b2ac...

Current branch diff-target is up to date.

Changes applied before test

commit ab849109ea1dac70d597316f3183e91742e6cb6c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 14 17:21:26 2022 +0100

    save_code_now: Allow request creation if previous for origin is running
    
    Previously, the save code now service was not allowing to create a new
    request for an origin if a previously created one for the same origin
    was currently running.
    
    However, new commits might have been pushed to the origin while a loading
    task is running so this restriction does not make sense, especially for
    the new forge webhook receivers feature.
    
    Related to T4548

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2139/ for more details.

Harbormaster completed remote builds in B32833: Diff 31900.Nov 16 2022, 3:26 PM

Closed by commit rDWAPPSab849109ea1d: save_code_now: Allow request creation if previous for origin is running (authored by anlambert). · Explain WhyNov 16 2022, 3:29 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSab849109ea1d: save_code_now: Allow request creation if previous for origin is running.