bin/pip-swh-packages: Basic fix
ClosedPublic
Actions

Authored by ardumont on Jan 7 2019, 11:50 AM.

Details

Reviewers

seirl

Group Reviewers

Reviewers

Commits

rDENVb83c0e8df904: bin/ls-py-modules: Fix typo in error message
rDENV6281020252f0: pip-swh-packages: Fix extra category deps when using testing flag

Summary

As a proof that fixing what's described in T1454 makes the `pip
install` instruction work.

pip-swh-packages depends on the py-depgraph script. That script is
used for the graphviz dependency schema generation. So the output
should not be changed (i think).

cons:

order is no longer completely respected (storage always the last)
swh-storage is hard-coded

pros:

it works

I do not see a better way to fix it yet (ideas welcome ;).

Related T1454

Test Plan

pip install $( ./bin/pip-swh-packages --with-testing )

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jan 7 2019, 11:50 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 7 2019, 11:50 AM

Harbormaster failed remote builds in B3255: Diff 2807!Jan 7 2019, 11:50 AM

ardumont edited the summary of this revision. (Show Details)Jan 7 2019, 11:51 AM

This looks like the right time to rewrite these complicated bash scripts in Python

This looks like the right time to rewrite these complicated bash scripts in Python

yes, it could be.

Digging a little further, the swh.storage[schemata,listener] is coming from the swh-docs's requirements-swh.txt (which sounds reasonable for building purposes i guess).