Page MenuHomeSoftware Heritage

bin/pip-swh-packages: Basic fix
ClosedPublic

Authored by ardumont on Jan 7 2019, 11:50 AM.

Details

Summary

As a proof that fixing what's described in T1454 makes the `pip
install` instruction work.

pip-swh-packages depends on the py-depgraph script. That script is
used for the graphviz dependency schema generation. So the output
should not be changed (i think).

cons:

  • order is no longer completely respected (storage always the last)
  • swh-storage is hard-coded

pros:

  • it works

I do not see a better way to fix it yet (ideas welcome ;).

Related T1454

Test Plan

pip install $( ./bin/pip-swh-packages --with-testing )

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jan 7 2019, 11:50 AM
ardumont edited the summary of this revision. (Show Details)Jan 7 2019, 11:51 AM

This looks like the right time to rewrite these complicated bash scripts in Python

This looks like the right time to rewrite these complicated bash scripts in Python

yes, it could be.


Digging a little further, the swh.storage[schemata,listener] is coming from the swh-docs's requirements-swh.txt (which sounds reasonable for building purposes i guess).

ardumont updated this revision to Diff 2809.Jan 7 2019, 1:44 PM

Improve fix implementation:

  • pip-swh-packages: Fix extra category deps when using testing flag

And:

  • bin/ls-py-modules: Fix typo in error message
ardumont edited the summary of this revision. (Show Details)Jan 7 2019, 1:44 PM
seirl accepted this revision.Jan 7 2019, 1:45 PM
This revision is now accepted and ready to land.Jan 7 2019, 1:45 PM
seirl added a comment.EditedJan 7 2019, 1:46 PM

This looks like the right time to rewrite these complicated bash scripts in Python

How do you downvote a comment in Phabricator? :P

This revision was automatically updated to reflect the committed changes.