Differential D8810

cli: Increase open file descriptor limit to support 256 open LevelDBs
ClosedPublic
Actions

Authored by vlorentz on Nov 4 2022, 10:19 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDDATASETb2ae082661f3: cli: Increase open file descriptor limit to support 256 open LevelDBs

Diff Detail

Repository

rDDATASET Datasets

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32713
Build 51254: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51253: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 4 2022, 10:19 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 4 2022, 10:19 AM

Build is green

Patch application report for D8810 (id=31743)

Rebasing onto 735397ac85...

Current branch diff-target is up to date.

Changes applied before test

commit cd9408c65fffbb57b528d6f1c7907ea99aa3ba37
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Nov 4 10:18:56 2022 +0100

    cli: Increase open file descriptor limit to support 256 open LevelDBs

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/155/ for more details.

Harbormaster completed remote builds in B32698: Diff 31743.Nov 4 2022, 10:21 AM

vlorentz requested review of this revision.Nov 4 2022, 10:21 AM

Thanks; I have one comment inline that I think should be addressed!

swh/dataset/cli.py
149–153	The logging is inconsistent with the actual new value of the limit, which may end up surprising people

This revision is now accepted and ready to land.Nov 4 2022, 3:52 PM

clamp before logging

Build is green

Patch application report for D8810 (id=31760)

Rebasing onto 735397ac85...

Current branch diff-target is up to date.

Changes applied before test

commit b2ae082661f39833e11479292641b233dadfe044
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Nov 4 10:18:56 2022 +0100

    cli: Increase open file descriptor limit to support 256 open LevelDBs

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/156/ for more details.

Harbormaster completed remote builds in B32713: Diff 31760.Nov 4 2022, 4:08 PM

Closed by commit rDDATASETb2ae082661f3: cli: Increase open file descriptor limit to support 256 open LevelDBs (authored by vlorentz). · Explain WhyNov 4 2022, 4:10 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDATASETb2ae082661f3: cli: Increase open file descriptor limit to support 256 open LevelDBs.